Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change images to use ARG for versions checksums etc. #245

Closed
nigelgbanks opened this issue Sep 7, 2022 · 2 comments
Closed

Change images to use ARG for versions checksums etc. #245

nigelgbanks opened this issue Sep 7, 2022 · 2 comments
Labels
refactor

Comments

@nigelgbanks
Copy link
Contributor

Brought up here: #244 (comment) this change would make it easier for people to raise pull requests with version bumps.
@nigelgbanks nigelgbanks mentioned this issue Sep 7, 2022
Merged
@nigelgbanks
Copy link
Contributor Author

Might have a negative effect on caching...

Tested locally and if the ARG doesn't change, it doesn't affect the downstream RUN statements caching. So it should be fine, it simply prepends the variable onto the RUN statement, so it's functionally equivalent. It does create additional layers, but whatever.

@nigelgbanks
Copy link
Contributor Author

Done under #238 does not have a negative effect on caching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nigelgbanks