Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Drupal JWT keys in Syn too #7

Closed
wants to merge 1 commit into from

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Aug 29, 2017

Simply Resolves Islandora/documentation#702

This is very basic and only good for single server setups.

It will need more to do actual copying of a JWT if Fedora and Drupal are on separate machines.

@whikloj
Copy link
Member Author

whikloj commented Aug 29, 2017

Probably easiest to test after Islandora/documentation#690 and Islandora/documentation#692 are merged.

@DiegoPino
Copy link
Contributor

@whikloj ok, will hurry up then.

@@ -1,3 +1,5 @@
---

webserver_app: yes
webserver_app_jwt_key_path: /home/ubuntu/auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a few comments about allowing multi platform approaches for our ansible playbook. Where would this one be if using Centos/Redhat?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be where ever you wanted to store these keys. Could be /etc/ssl if you so choose, but you'd have to make that directory. This directory is generated when the SSL keys are made, so all I am doing is copying the variable up to a higher point to allow both roles to access it the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then i guess we need to make this platform independent, you run Redhat right?
This here is just for ubuntu:
https://github.com/Islandora-Devops/claw-playbook/blob/3efb1326addd71f0933d7945ea1bddf15cd0e7cc/inventory/vagrant/group_vars/tomcat.yml#L29
Mostly because every sprint issue we have right now says we should
try supports both Ubuntu and CENTOS. Just a comment because seems like that is one of the advantages of ansible at all (other than learning a new pseudo language we will forget if not using it on a daily basis)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathangreen @whikloj probably

webserver_app_jwt_key_path:  {{ fcrepo_syn_sites[path] | default(/home/ubuntu/auth) }}

Not sure about the fcrepo_syn_sites: path: nomenclature (way of accesing) but i would for sure think we should reuse as much vars as possible

@dannylamb
Copy link
Member

@whikloj Whenever you get a chance, can you try rebasing this? I'll gladly test. Once this is done, we're at feature parity (and a bit more, I'd say) and can deprecate claw_vagrant 🎉

@whikloj
Copy link
Member Author

whikloj commented Sep 22, 2017

Rebasing and testing

@whikloj
Copy link
Member Author

whikloj commented Nov 15, 2017

This PR was replaced by #25

@whikloj whikloj closed this Nov 15, 2017
@whikloj whikloj deleted the issue-702 branch November 24, 2017 18:59
birkland added a commit to birkland/claw-playbook that referenced this pull request Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants