-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cycling Api-X stack and loading Crayfish microservices into Api-X #22
Conversation
I really feel that with the complete gutting of Alpaca in Islandora/documentation#640 we should hold off on these PRs and get that merged. I know @dannylamb wanted to wait until after the sprint to avoid causing havok, but once the sprint is done we should prioritize merging 640. Then review all open tickets around the API-X/Karaf cycling. |
@whikloj Now that Islandora/documentation#640 is in, I've tested and this is still needed. The stack starts up at least, but API-X's discovery services won't work without the cycling in this PR. 😭 |
@dannylamb so I haven't had a lot of time to look at this, but my first thought is we probably don't want API-X pulling in the services. If they aren't getting registered, perhaps we can make the individual service send out a notification that API-X handles by doing the restart. That way if we add more microservices we don't have to update the API-X role for each. |
@whikloj Yeah, that makes sense. I'll circle back around to this soon and see what I can do. |
@whikloj Ok, I pushed the loading of services into the crayfish role and shuffled around some config. I'm testing it out now. |
Looks like I broke things when merging #45. I'm going to test to confirm. |
@dannylamb I know you are busy, but if this PR is related to this error.
Maybe we should get it rebased and I can test it out. Or at least give us some steps to resolve it, because I can't update an islandora_image now. |
That one seems to be related to the root element, here is when trying to add a description to an already synced islandora_collection.
|
Nevermind, I guess this is not related. It was one part browser cache and one part failed update. But in the end this was not the problem. |
@dannylamb what do we think about this PR? Should we wait until API-X is working with Fedora 5.0.0 and see if we still need it? |
Let's close it and I'll re-do things once API-X is a go. |
Resolves: https://github.com/Islandora-CLAW/CLAW#738 and https://github.com/Islandora-CLAW/CLAW#739
Adds two tasks with the tags
apix-reset
cycles karaf, tomcat, and activemq with waits inbetween to address fcrepo4-labs/fcrepo-api-x#149.apix-crayfish
loads our crayfish microservices into Api-X via its loader service.Setup
If you're bringing up a new box environment with these changes, you don't need to do anything else before testing. If you have an existing environment, you can pull in these changes and run the tasks with
ansible-playbook -i inventory/vagrant -t apix-reset,apix-crayfish playbook.yml
.Both check conditions and skip running when not neccessary, so they should be idempotent. You should run them again and verify.
Testing
You should see three service instances. One for ocr, convert, and identify.