Installation for Issue 887 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
whikloj
reviewed
May 18, 2019
| @@ -1,5 +1,7 @@ | |||
| --- | |||
|
|
|||
| crayfish_version_tag: dev-format_jsonld_strip | |||
There was a problem hiding this comment.
The dev- here caused this to fail for me. Not sure why.
There was a problem hiding this comment.
This particular line failed for me because the ansible-role-crayfish still referenced the main Crayfish repo in the install task instead of @dannylamb's fork. Once I updated my local copy of the install task it worked fine.
whikloj
reviewed
May 18, 2019
|
@seth-shaw-unlv @whikloj This is ready to go now that all applicable PRs have been merged. |
|
Doing a final spin-up before approval and merge. |
It would help if I cleaned out my external roles first... 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will install everything you need to test the changes for Islandora/documentation#887.
See the issue for testing instructions.