Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter JWT claims to use standard ones. #15

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Jan 22, 2018

GitHub Issue: Islandora/documentation#736

Depends on: Islandora/documentation#73
Related to: Islandora/Syn#11

What does this Pull Request do?

Alters expected claims in an Islandora CLAW JWT.

What's new?

uid -> webid

name -> sub

url -> iss

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

See the testing instructions here (Islandora/Syn#11) they pull in the changes to Syn, islandora and Crayfish-Commons.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage     91.04%   91.04%           
  Complexity      111      111           
=========================================
  Files             8        8           
  Lines           335      335           
=========================================
  Hits            305      305           
  Misses           30       30
Impacted Files Coverage Δ Complexity Δ
src/Syn/JwtAuthenticator.php 96.2% <100%> (ø) 23 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33b7963...3cf0605. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants