Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: new content from hack/doc "Getting Started with Islandora CLAW" #650

Merged

Conversation

ysuarez
Copy link
Contributor

@ysuarez ysuarez commented May 29, 2017

GitHub Issue: #632

  • Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.)

This is the Google doc created during the 2017 Islandoracon Hack/doc where I got the content from:
https://docs.google.com/document/d/1CN7mBYdU-ACYoDwWFncUwLPD2bLpt2FKG9CuT63_Pps/edit#heading=h.ptidptu8k2h

The older documentation I used as a basic guide:
https://wiki.duraspace.org/display/ISLANDORA/Getting+Started+with+Islandora

https://wiki.duraspace.org/display/ISLANDORA/How+to+Add+an+Item+to+a+Digital+Collection

What does this Pull Request do?

  • Added a new docs section to the 'User documentation' section, called 'Getting Started with Islandora CLAW'
  • This is only a start of the work that needs to be done to convert the Google Doc from the hack/doc. Also this my first opportunity to get my first PR feedback. This is also a chance to start getting initial feedback on things like the section name I chose and the formatting style I chose to use so far.

What's new?

  • A new navigation section under 'User documentation" called 'Getting Started with Islandora CLAW'
  • Some content from the above Google Doc converted to MarkDown

How should this be tested?

Please read over to find:

  • grammar & spelling errors
  • discrepancies in what the docs explain versus how the current CLAW build UI looks like or behaves

Please add comments on how the documentation should be extended or changed, or add additional PRs with new changes.

Additional Notes:

For the record, I emailed my CLA to the "community" email address on May 20, 2017. Did not get a response, but the CLA should be on file by now.

Interested parties

@Islandora-CLAW/committers
@kimpham54

@ruebot
Copy link
Member

ruebot commented May 29, 2017

Thanks for this @ysuarez! I'll comment inline on the PR.

11. Revision log message
12. Click "Save" button.
13. Once you upload a file, you can Edit or Remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove erogenous whitespace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, it's too stimulating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I totally missed that. Will be on the lookout for these extra spaces going forward.

## Administrative Tasks

### How to Add an Item to a Collection
1. Click the **Manage** tab from the top toolbar.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have an "How to Add an Item to a Collection", there needs to be a "How to Add a Collection" before it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll work on this, if someone doesn't get to it before I do. I am still learning CLAW, but I may be able to write out the basics steps by trying it out on my CLAW VM.

1. Click the **Manage** tab from the top toolbar.
2. Select **People** tab from the resulting menu.
3. Click the **Permissions** tab in the set of tabs above the Add User button.
4. Click the blue botton “Add role”
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use smart quotes.

3. Select **People** tab from the resulting menu.
![Alt text](../assets/people_page.png "People page")
4. Enter all the required fields, as indicated by red asterisks, in the Add User page.
5. Click on “Create New Account” button at the bottom of the page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use smart quotes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, this came from the Google Doc and I missed them. I should have known to look for them, smart quotes have burned me in the past.

## How to Add a User
1. Log in under admin credentials.
2. Click the **Manage** tab from the top toolbar.
3. Select **People** tab from the resulting menu.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are inconsistencies with items that are wrapped in quotes, and items that are bolded. Is there a distinct difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree. I mostly followed what the hack/doc participants had created in the Google Doc, and it had these inconsistencies. I was not suse which practices were preferred, but initially I wanted to just follow what they did until I got feedback from the community/committers.

Is there a community documentation standard I should follow or a place I could look it up? For example, in some docs they format all menu or button labels in a particular style like bold or italics. In the Google Doc sometimes they used bold or sometimes they used quotes. Once I am given guidelines or if I find them on my own, I can reformat what I have done so far as well as continue the practice with the content that is left in the Google Doc. In the meantime, I will look over some of the docs on the Islandora wiki more carefully to see what has been done in the past.

One thing I did change from the original hack/doc content was to enforce the use of the word "click" instead of "select" when the contents referred to clicking a button, tab or link.

6. Click the **Save** button.
7. To edit the permission for a role, click on the **Edit** dropdown menu to the right of the role and select **Edit Permissions**.
8. Scroll down until you see the “Islandora section” of options. (Currently this is the very bottom of a very long page)
1. Resource ‘type’ is what you’ll most often deal with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use smart quotes.

3. RDF is a Fedora resource
4. RDF Source (i.e. descriptive information) is a Resource
5. Collections are now considered a type
6. Audio, Images, etc are also going to be types (this might require changes in the vocabulary we use Drupal “entities” (i.e. your core set of elements) and Drupal “bundles” (includes your entities plus other elements)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use smart quotes.

1. Log in under admin credentials.
2. Click the **Manage** tab from the top toolbar.
3. Select **People** tab from the resulting menu.
![Alt text](../assets/people_page.png "People page")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be more screenshots? It seems inconsistent to only have one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question This is again what the hack/doc document had. I started making some new screenshots, but I wanted to get this feedback first. @kimpham54 this morning already made a PR on my CLAW fork with additional screenshots I will soon include in this PR.

4. Click on "Add fedora resource" button.
5. Click on "Islandora image" link. This will load the "Create of bundle Islandora image" page.
6. Fill out form fields. [NOTE: currently the generation of image derivatives is not supported.]
1. Name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sub-items should be bullets, not Roman numerals.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but that is how it looked on the Google Doc. I will make the change.

### How to Add an Item to a Collection
1. Click the **Manage** tab from the top toolbar.
2. Select **Content** tab from the resulting menu.
3. Click on **Fedora Resources*** tab (3rd tab).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extra asterisk at the end of Fedora Resources.

3. memberOf
1. This field will auto-populate
4. Description
5. OJB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo OJB, should be OBJ

@whikloj
Copy link
Member

whikloj commented May 29, 2017

👍 Nice work @ysuarez. Great first pass at getting the Google doc into Github, just a couple fixes to make.

As for the bold versus "quoted" debate, I would stick with bold for things you click on (like buttons or links). For the title of a page or section, that is up to you.

1. Name
2. Authored by
3. memberOf
1. This field will auto-populate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If sub-items are going to be bullets, then this sub-sub-item should probably also be a bullet. 😃

Related to PR Islandora#650

* removed smart quotes
* changed list type to bulleted list
@ysuarez
Copy link
Contributor Author

ysuarez commented May 29, 2017

@whikloj Thanks for the suggestions on formatting UI labels. I made a note of it for this PR and for future documentation work. I may not have time today to make the changes, but I can work on it later this week. Sadly this may be reason enough to block this PR, and I understand, but I am open to having others create a PR from my forked repo in the meantime.

@ruebot thanks again for all the feedback

@kimpham54 thanks for your PR

@whikloj
Copy link
Member

whikloj commented May 29, 2017

@ysuarez I don't think there is a rush on this. If you want to (and can) keep moving this along, it can sit for now.

There are other parts of the original Google Doc that can be picked up by others to either create new documentation or extend the existing docs.

@ruebot
Copy link
Member

ruebot commented May 31, 2017

This will need to be updated once #643 lands.

Does anybody want to volunteer to help test that PR, and create documentation in the process?

@ysuarez
Copy link
Contributor Author

ysuarez commented May 31, 2017

@ruebot (@whikloj @whikloj and to others) I just pushed two new commits to standardize the UI label formatting. I also added a section for "How to Create a Collection."

There are still about 10 more "How to" sections in the Hack/doc Google Doc, but many are not as fleshed out as the ones I have formatted so far.

I can continue simplifying/editing and formatting the rest in this PR or a separate one, and then await feedback on what content needs to be fixed/updated.

For the record, here are the titles of most of remaining sections...

  • How to edit an object’s metadata
  • How to edit multiple objects
  • How to delete an object
  • How to add an object to multiple collections
  • How to purge/delete objects
  • How to delete a collection and all of its child objects
  • How to batch delete multiple objects
  • How to make mass edits and/or find and replace
  • How to review mapping of Metadata fields in an object

Wondering if some of these sections should be placed in the new 'Getting Started with Islandora CLAW' or should a new page be created?

Thoughts? Thanks.

@ruebot
Copy link
Member

ruebot commented May 31, 2017

Ideally they would all be sub-sections of "Getting Started with Islandora CLAW".

@ysuarez
Copy link
Contributor Author

ysuarez commented Jun 1, 2017

@ruebot I can take care of updating these docs if/when #643 is merged. (I needed to read the details of #643 before I could comment.)

Glad to see that some testing has been done so far.

6. Click the **Save** button.
7. To edit the permissions for a role, click on the **Edit** dropdown menu to the right of the role and select **Edit Permissions**.
8. Scroll down until you see the *Islandora section* of options. (Currently this is the very bottom of a very long page)
* Resource ‘type’ is what you’ll most often deal with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking out loud here, but should we add a screen shot here? Or could that lead us into a 🐰 hole of un-imaginable depth over time?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysuarez Recapping our IRC conversation (starting @ 13:32). The rabbit hole is once more permissions get added, keeping a screenshot of them could be problematic.

However, currently there is only one section of permissions and as this is a Getting Started with Islandora CLAW document, maybe a single screenshot with some permissions is good enough. 🤷‍♂️

Here is some of the current permissions lines now using Nodes.
islandora_permission

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we can add a basic screenshot with the first couple of rows of relevant CLAW permissions

@whikloj
Copy link
Member

whikloj commented Jun 2, 2017

@ysuarez awesome work.
#643 is a re-architecting. So it will affect where the permissions are (they have moved under Node and appear like Islandora Collection: Create new content)
Also it affects creating content, in that you just go to the Add Content page now.
But the rest has not really changed.

@ysuarez
Copy link
Contributor Author

ysuarez commented Jun 2, 2017

Now that I have figured on that I was confusing Github Issues and Github Pull Requests thanks to @whikloj, I am no longer confused.

I will wait for the vagrant build to be ready so I can try out the new functionality an update this pull request. Of course anyone is welcome to contribute too.

My understanding so far is that we need to update the sections on:

  • "How to Create a New User Role"
    • update the sub-section on changing permissions
  • "How to Create a Collection"
  • "How to Add an Item to a Collection"

6. Click the **Save** button.
7. To edit the permissions for a role, click on the **Edit** dropdown menu to the right of the role and select **Edit Permissions**.
8. Scroll down until you see the *Node* section of options, until you see options that have an *Islandora* preffix. For example, *Islandora Collection: Create new content*.
* Resource ‘type’ is what you’ll most often deal with
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we need lines 23-28. Let me know what you all think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't know if that makes sense anymore. I also think it might be overly complex for a "getting started" document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whikloj thanks for the feedback. I took that content out.

* I.e. use the course code for a particular class of students working on a particular collection.
6. Click the **Save** button.
7. To edit the permissions for a role, click on the **Edit** dropdown menu to the right of the role and select **Edit Permissions**.
8. Scroll down until you see the *Node* section of options, until you see options that have an *Islandora* preffix. For example, *Islandora Collection: Create new content*.
Copy link
Member

@whikloj whikloj Jun 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little things.

  1. "Scroll down until you see the Node section of options, until you see the options that have an..."
    The language is jumbly.
  2. Typo preffix, should be prefix

@whikloj
Copy link
Member

whikloj commented Jun 13, 2017

Looking good @ysuarez. If you can fix up that sentence, I think we might be good for this PR. @ruebot do you have any other concerns?

@ruebot
Copy link
Member

ruebot commented Jun 13, 2017

👋 from 🇬🇧

Carry on 😄

@ysuarez
Copy link
Contributor Author

ysuarez commented Jun 13, 2017

@whikloj good points.

I changed the phrasing to...
"8. Scroll down until you see the Node section of options, then look for the options that have an Islandora prefix. For example, Islandora Collection: Create new content."

Let me know if I should make other changes.

@dannylamb dannylamb merged commit a7a5df1 into Islandora:master Jun 14, 2017
@dannylamb
Copy link
Contributor

@ysuarez++ Thanks for this!

@ysuarez ysuarez deleted the docs_getting_started_with_islandora_claw branch June 14, 2017 15:20
@whikloj
Copy link
Member

whikloj commented Jun 14, 2017

@ysuarez nice work, thanks for carrying it through to the end. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants