Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derivatives try to use source media type #986

Closed
whikloj opened this issue Dec 6, 2018 · 0 comments
Closed

Derivatives try to use source media type #986

whikloj opened this issue Dec 6, 2018 · 0 comments
Assignees
@whikloj

Comments

@whikloj
Copy link
Member

whikloj commented Dec 6, 2018

Coming out of #103 we are now using the source media bundle when putting a derivative back into Drupal.

Before it was hard-coded
https://github.com/Islandora-CLAW/islandora_image/blob/8.x-1.x/src/Plugin/Action/GenerateImageDerivative.php#L174

Then I made it relative to the source_media
https://github.com/Islandora-CLAW/islandora/blob/8.x-1.x/src/Plugin/Action/AbstractGenerateDerivative.php#L168

This causes a problem for Tiffs as they are files but their Service file is an image.
@whikloj whikloj self-assigned this Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whikloj whikloj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whikloj