Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working when used as child process #57

Closed
rtwk opened this issue Nov 2, 2016 · 12 comments
Closed

Not working when used as child process #57

rtwk opened this issue Nov 2, 2016 · 12 comments

Comments

@rtwk
Copy link

rtwk commented Nov 2, 2016

I was using web-term as child process. And it was working fine. But after updating to the latest version (node v6>), it fails to start web-term as child process. It works when started from terminal directly though.

@IonicaBizau
Copy link
Owner

Just observed the same error. 👍

As side effect, the -d option is not working too... Help is appreciated!

Other modules are affected and I'm not sure how to solve it...

@rtwk
Copy link
Author

rtwk commented Nov 2, 2016

-d option is working in my case. But no luck with starting it a as a child process.

@IonicaBizau
Copy link
Owner

Interesting! So, after doing web-term -d -p 9000 are you able to open the localhost:9000?

@rtwk
Copy link
Author

rtwk commented Nov 2, 2016

No it is not accessible over http. But the daemon seems to start. At least not throwing any error message. May be you are right. It does not start at all.

@IonicaBizau
Copy link
Owner

Yes, no error, but it fails to start for the same reason. I think it's breaking because of the new version of Node, but don't understand why.

@rtwk
Copy link
Author

rtwk commented Nov 2, 2016

This is very strange. It starts when started from terminal but you call it from nodejs code as a child process and it fails.

@IonicaBizau
Copy link
Owner

Exactly...

@rtwk
Copy link
Author

rtwk commented Nov 2, 2016

Is it because new version of node or because it is rewrite in ES6

@IonicaBizau
Copy link
Owner

It's not because of rewrite. It makes me think it's because of the new Tilda versions (>=4.4.0):

https://github.com/IonicaBizau/tilda

There I added some process.stdin things which are related to this behavior....

@IonicaBizau
Copy link
Owner

Confirming it's a bug in Tilda: IonicaBizau/tilda#11

I'm on it.

@IonicaBizau IonicaBizau self-assigned this Nov 14, 2016
@IonicaBizau
Copy link
Owner

Isolated this case: http://stackoverflow.com/q/40588859/1420197

@IonicaBizau
Copy link
Owner

@rtwk When you want to start it as child process, use spawno or specify stdio: ["inherit"] in the spawn options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants