[BUG] - query ledger-state outputs CBOR after nodes upgrade

[mkoura]

Internal if an IOHK staff member.

Area
Other Any other topic (Delegation, Ranking, ...).

Summary
After upgrading nodes of local cluster from release 1.34.1 to current master, the cardano-cli query ledger-state --testnet-magic 42 --cardano-mode command no longer outputs JSON, but CBOR.

Steps to reproduce
Steps used to reproduce the behavior:

1. run local cluster nodes with release 1.24.1
2. run QA smoke tests
3. restart cluster nodes with binaries built from current master
4. run smoke tests again
5. see the error

The resulting output:
upgraded_ledger_state.json.gz

System info (please complete the following information):

• OS Name: Fedora 35
• Node version: 0e242043aa4d94b1e0a7ac28dc3b3bc1fb2d25d7

[mkoura]

The query protocol-state now returns CBOR as well. Same situation as in the original issue (upgraded node).

[dorin100]

@mkoura - is query stake-snapshot in the same situation as the above 2 commands?

[mkoura]

@dorin100 per our new automated tests for this issue, following commands are affected:

• query ledger-state
• query protocol-state
• query stake-snapshot
• query pool-params

[Jimbo4350]

@mkoura can you confirm the following commands still output CBOR:

• query ledger-state -> Outputs JSON for me
• query protocol-state -> Outputs JSON for me
• query stake-snapshot -> Outputs JSON for me
• query pool-params -> Outputs JSON for me

[saratomaz]

Fixed, the commands are already returning json.

Verified with the following tests:
test_ledger_state
test_stake_snapshot
test_pool_params
test_protocol_state_keys

[mkoura]

Not fixed, the important part is "After upgrading nodes of local cluster from release 1.34.1 to current master". We still get CBOR instead of JSON in this scenario.

[Jimbo4350]

@mkoura I just tested current master. Please paste your commands, outputs and cli + node revisions

[mkoura]

Not sure if this can be tested in isolation. Our job does following:

• start local network with node version running on mainnet (1.34.1 atm)
• run smoke tests (370+), so there is some history
• upgrade cardano-node to latest master and restart node processes with updated binaries
• re-run all smoke tests

After the node is upgraded to master (f5161e5bee1c733c56557e202e22e636c845634f in last failed job), we run simple query with output to stdout (without --out-file) in the failing tests. At the moment I've got only output of cardano-cli query protocol-state available in testing artifacts - test_protocol_state_keys_ci0_nge_protocol_state.out.gz

I'll play with it more after my PTO if needed.

[Jimbo4350]

Current master is 621311f495dd4ed471482527104e256ac6971464 which is what I tried it with.

I'll play with it more after my PTO if needed.

Please don't respond if you are on PTO :)

[mkoura]

Sorry, wrong rev, we tested it with commit 2be07bb during last nightly run.

[Jimbo4350]

@mkoura Can you test it with the latest master? It's working for @saratomaz and myself.

[mkoura]

Still the same issue on 803881b

It is not working for @saratomaz, she didn't test is on upgraded nodes, which is a required condition.
All the affected commands work if the nodes were NOT upgraded.

[newhoggy]

cardano-cli falls back to CBOR when it can't decode the CBOR binary data it gets from node which can happen if the version mismatches.

Please verify that the version of cardano-cli matches exactly with the version of cardano-node that the cardano-cli is connecting to.

[CarlosLopezDeLara]

Closing as non-issue. We have confirmation that there was a problem related to the use of different node and cli versions.