Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/cardano-launcher script doesn't work for windows #12

Closed
rvl opened this issue Feb 19, 2020 · 2 comments · Fixed by #53
Closed

bin/cardano-launcher script doesn't work for windows #12

rvl opened this issue Feb 19, 2020 · 2 comments · Fixed by #53
Assignees

Comments

@rvl
Copy link
Contributor

rvl commented Feb 19, 2020

There is a nodejs wrapper script bin/cardano-launcher which executes the testing CLI, but it has some problems.

  1. It requires an npm build to have been done first, because it uses dist/index.js.

  2. src/index.ts gets polluted with CLI code. There should be a separate module the cli.ts.

  3. It doesn't work for windows, which means the integration tests don't pass.

There must be a "proper" way to configure cross-platform executable CLI scripts for typescript apps, but I have no idea how to do it...

@rhyslbw
Copy link
Collaborator

rhyslbw commented Mar 27, 2020

The best solution for keeping the CLI code out of the library bundle is blocked by either:
jaredpalmer/tsdx#535 or jaredpalmer/tsdx#367

In the mean-time I'll separate the source code and target each one separately

@rvl
Copy link
Contributor Author

rvl commented Mar 27, 2020

Keeping the CLI code out of the library bundle would be nice to have but not essential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants