Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGPlay is stuck #74

Closed
romain-fontugne opened this issue Mar 29, 2022 · 11 comments
Closed

BGPlay is stuck #74

romain-fontugne opened this issue Mar 29, 2022 · 11 comments
Assignees
Labels
beginner-friendly bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed javascript

Comments

@romain-fontugne
Copy link
Member

Describe the bug
We used to have a working version on BGPlay on IHR website. Somehow this is not working anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://ihr.iijlab.net/ihr/en-us/networks/AS2497
  2. Click on the AS dependency graph
  3. Scroll down to the table below the graph and click on 'AS GRAPH'
  4. The message 'Reconstructing the history.' is shown indefinitely and no graph appear

Expected behavior
We are supposed to see the BGPlay graph: https://stat.ripe.net/widget/bgplay#w.resource=2497

Desktop (please complete the following information):

  • OS: linux
  • Browser: brave
@Aniket762 Aniket762 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers beginner-friendly javascript labels Apr 29, 2022
@VenomFate-619
Copy link
Contributor

There is no option for 'AS GRAPH' present.

@thisiskaransgit
Copy link
Contributor

Hey @VenomFate-619, just do this

  1. Go to https://ihr.iijlab.net/ihr/en-us/networks/AS2497

  2. Click on any of the traces of the Graph
    Screenshot from 2022-12-23 23-37-47

  3. Scroll down, you will be able to see the option for AS-Graph
    Screenshot from 2022-12-23 23-38-38

@romain-fontugne
Copy link
Member Author

I have been told that we should directly use bgplay code (https://github.com/massimocandela/BGPlay). Currently we are using a version provided by RIPE and that one seem to have some issues

@volfiros
Copy link
Contributor

Can I get more details about this issue and a few suggestions on how to resolve the bug @romain-fontugne.

@romain-fontugne
Copy link
Member Author

As described above by @thisiskaransgit we have a tab to show BGPlay. The code we are using is provided by ripe, but I think instead of this we should try to integrate BGPlay code (https://github.com/massimocandela/BGPlay) directly to IHR website

@J0SAL
Copy link
Contributor

J0SAL commented Jan 24, 2023

Hey @romain-fontugne, I'm a beginner to opensource and would love to work on this issue, could you assign this to me and some ideas on how to solve it?

@romain-fontugne
Copy link
Member Author

to resolve this issue you'll have to look at BGPlay code first: https://github.com/massimocandela/BGPlay
Try to get BGPlay working on its own and then try to integrate it with IHR website

@VenomFate-619
Copy link
Contributor

I tried to resolve this.
my approach to fix this is as follows:-
need to host the bgplay code on a server, I think forking the code and using that GitHub link would work
need to change the BGPLAY_PROJECT_URL in bgplayjs-main-widget.js fike of bgplay repo, this link might be like
image

https://github.com/InternetHealthReport/bgplay
at frontend, we need to add bg-play repo link in the libraries

image

image

The following issue needs to be handled:
the size of the widget currently is going too big for the container and if we make it
the loading time, for a while a white screen is coming as it is downloading the js files
not able to find an equalizing to this.bgplay.reload()
the widget returns the following

{
    "domId": "bgplay",
    "initialParams": {
        "width": 1100,
        "height": 800
    },
    "queryParams": {
        "resource": "193.0.0.0/21",
        "collectorPeers": "all",
        "unix_timestamps": "TRUE",
        "showResourceController": true,
        "ignoreReannouncements": "true",
        "rrcs": "10",
        "type": "bgp"
    },
"shell": {
get_params: ƒ (),
set_params: ƒ (params)
}
}

if this looks fine can I take up that issue?

@romain-fontugne
Copy link
Member Author

@VenomFate-619 I have assigned you for this issue

@VenomFate-619
Copy link
Contributor

@romain-fontugne do close this issue

@romain-fontugne
Copy link
Member Author

yep, thanks again for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed javascript
Projects
None yet
Development

No branches or pull requests

6 participants