Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogEntry + Shape #575

Merged
merged 8 commits into from
Aug 11, 2022
Merged

Add LogEntry + Shape #575

merged 8 commits into from
Aug 11, 2022

Conversation

PHochmann
Copy link
Contributor

No description provided.

@kragall
Copy link

kragall commented Jun 30, 2022

Hi, so I checked with the current version of the Clearing House and saw that the originally requested structure doesn't fit anymore. So I wondered if it's possible to adjust the changes to fit this structure:

  • timestamp: This is the timestamp recording the date when this message was logged by the CH
  • transaction_id: This is basically a counter with a unique (unique in the database) number for each stored message.
  • process_id: This is a string that describes the process under which the message is logged. Think of it as the label of the folder under which the message has been filed together with other messages.
  • document_id: This is a unique (unique in the process) id in the form of a uuid for the stored message
  • client_id: This is the unique id of the client that sent the stored message taken from the DAT the client sent with the original LogMessage
  • server_id: This is the unique id of the server that stored message in form of the id of private key
  • hash: This information is used for integrity protection in the CH
  • signature: This contains a cryptographic signature of the data
  • payload: This optional field contains the payload of the original LogMessage

Please note that in the original request LogEntry contained a LogMessage. This is not the case anymore.

@PHochmann
Copy link
Contributor Author

Hi, so I checked with the current version of the Clearing House and saw that the originally requested structure doesn't fit anymore. So I wondered if it's possible to adjust the changes to fit this structure:
* payload: This optional field contains the payload of the original LogMessage

Is this payload a string or another Data Type property, or does it point to another object? I can't find any information about what a LogMessage's payload looks like.

@kragall
Copy link

kragall commented Jul 11, 2022

The payload does not reference another entity, so it's probably best to use a string

@JohannesLipp
Copy link
Member

The payload does not reference another entity, so it's probably best to use a string

Thanks for the info! @PHochmann please implement it as DatatypeProp with xsd:string then. Thank you in advance!

@PHochmann
Copy link
Contributor Author

Edits are under taxonomies/Message.ttl @kragall Please have a look

taxonomies/Message.ttl Outdated Show resolved Hide resolved
testing/taxonomies/MessageShape.ttl Outdated Show resolved Hide resolved
taxonomies/Message.ttl Show resolved Hide resolved
taxonomies/Message.ttl Outdated Show resolved Hide resolved
PHochmann and others added 2 commits August 1, 2022 12:12
Co-authored-by: Johannes Theissen-Lipp <15930331+JohannesLipp@users.noreply.github.com>
taxonomies/Message.ttl Outdated Show resolved Hide resolved
@PHochmann
Copy link
Contributor Author

All requested changes are now resolved, feel free to review and merge. Thanks!

@PHochmann PHochmann requested review from JohannesLipp and removed request for changqin26 August 10, 2022 16:01
@PHochmann PHochmann merged commit 9be722b into develop Aug 11, 2022
@PHochmann PHochmann deleted the feature/log-entry branch August 11, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants