Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider static in rsutil.h #6055

Closed
jerry73204 opened this issue Mar 13, 2020 · 2 comments
Closed

Consider static in rsutil.h #6055

jerry73204 opened this issue Mar 13, 2020 · 2 comments

Comments

@jerry73204
Copy link

Required Info
Camera Model D435
Firmware Version (no tool on linux)
Operating System & Version Arch Linux
Kernel Version (Linux Only) 5.5.6-arch1-1
Platform PC
SDK Version 2.23.1
Language C
Segment any

Issue Description

Currently I'm working on Rust bindings for librealsense2. I noticed all functions defined in rsutil.h
are static. It would be a trouble to generate FFI for static functions. Because static functions are limited to its object file, they cannot be linked by outer programs. I think it's not necessary to place static there since they are somewhat public to C/C++. Removing static would give convenience for building other language bindings.
@MartyG-RealSense
Copy link
Collaborator

I will label your message as a Feature Request and leave it open so that the RealsSense developers can track it and consider it. Thanks!

@ev-mp ev-mp mentioned this issue Aug 9, 2021
Merged
@MartyG-RealSense
Copy link
Collaborator

Closed due to the issue being addressed in librealsense version 2.49.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jerry73204 @MartyG-RealSense