From 3854baab244d340f4387b74682f931e7f3ef6c47 Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Mon, 7 Aug 2023 21:49:09 +0200 Subject: [PATCH 1/2] Resolved issue reported by Coverity tool --- dpnp/backend/kernels/dpnp_krnl_common.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dpnp/backend/kernels/dpnp_krnl_common.cpp b/dpnp/backend/kernels/dpnp_krnl_common.cpp index bf3102bd7cde..d99772dbe436 100644 --- a/dpnp/backend/kernels/dpnp_krnl_common.cpp +++ b/dpnp/backend/kernels/dpnp_krnl_common.cpp @@ -852,15 +852,15 @@ DPCTLSyclEventRef dpnp_matmul_c(DPCTLSyclQueueRef q_ref, { // using std::max for these ldx variables is required by math library const std::int64_t lda = - std::max(1UL, size_k); // First dimensions of array_1 + std::max(1UL, size_n); // First dimensions of array_1 const std::int64_t ldb = - std::max(1UL, size_n); // First dimensions of array_2 + std::max(1UL, size_k); // First dimensions of array_2 const std::int64_t ldc = std::max(1UL, size_n); // Fast dimensions of result event = mkl_blas::gemm(q, oneapi::mkl::transpose::nontrans, oneapi::mkl::transpose::nontrans, size_n, size_m, - size_k, _DataType(1), array_2, ldb, array_1, lda, + size_k, _DataType(1), array_2, lda, array_1, ldb, _DataType(0), result, ldc, dep_events); } else { From df757a932922093ab3893fb4acb075543ae62410 Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Tue, 8 Aug 2023 12:34:20 +0200 Subject: [PATCH 2/2] Renamed local variables and updated comments --- dpnp/backend/kernels/dpnp_krnl_common.cpp | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/dpnp/backend/kernels/dpnp_krnl_common.cpp b/dpnp/backend/kernels/dpnp_krnl_common.cpp index d99772dbe436..dd6c8119c1b8 100644 --- a/dpnp/backend/kernels/dpnp_krnl_common.cpp +++ b/dpnp/backend/kernels/dpnp_krnl_common.cpp @@ -851,17 +851,18 @@ DPCTLSyclEventRef dpnp_matmul_c(DPCTLSyclQueueRef q_ref, std::is_same<_DataType, float>::value) { // using std::max for these ldx variables is required by math library - const std::int64_t lda = - std::max(1UL, size_n); // First dimensions of array_1 - const std::int64_t ldb = - std::max(1UL, size_k); // First dimensions of array_2 - const std::int64_t ldc = + const std::int64_t ld_array_2 = + std::max(1UL, size_n); // First dimensions of array_2 + const std::int64_t ld_array_1 = + std::max(1UL, size_k); // First dimensions of array_1 + const std::int64_t ld_result = std::max(1UL, size_n); // Fast dimensions of result event = mkl_blas::gemm(q, oneapi::mkl::transpose::nontrans, oneapi::mkl::transpose::nontrans, size_n, size_m, - size_k, _DataType(1), array_2, lda, array_1, ldb, - _DataType(0), result, ldc, dep_events); + size_k, _DataType(1), array_2, ld_array_2, + array_1, ld_array_1, _DataType(0), result, + ld_result, dep_events); } else { // input1: M x K