Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetaDataDictionary::Print only prints [UNKNOWN_PRINT_CHARACTERISTICS] #1454

Closed
blowekamp opened this issue Nov 29, 2019 · 2 comments · Fixed by #4814
Closed

MetaDataDictionary::Print only prints [UNKNOWN_PRINT_CHARACTERISTICS] #1454

blowekamp opened this issue Nov 29, 2019 · 2 comments · Fixed by #4814
Assignees
@phcerdan
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Comments

@blowekamp
Copy link
Member

Description

For any MetaDataObject calling obj->Print(std::cout) produces "[UNKNOWN_PRINT_CHARACTERISTICS]" on the console.

ITK/Modules/Core/Common/include/itkMetaDataObject.hxx

Lines 63 to 69 in 6046976

template <typename MetaDataObjectType>
void
MetaDataObject<MetaDataObjectType>::Print(std::ostream & os) const
{
Superclass::Print(os);
}

Expected behavior

For itk::Object base objects the Print method should be used while those which support operator<<, that method should be used.

It is expected to be able to iterate over the metadata dictionary and print the key and value of all types and get descriptive output.
@blowekamp blowekamp added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Nov 29, 2019
@stale
Copy link

stale bot commented Mar 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the status:Backlog Postponed without a fixed deadline label Mar 28, 2020
@phcerdan phcerdan self-assigned this Dec 13, 2023
@stale stale bot removed the status:Backlog Postponed without a fixed deadline label Dec 13, 2023
@phcerdan
Copy link
Contributor

phcerdan commented Dec 13, 2023 •
edited
Loading

Facing this as well...

By the way @blowekamp, it would be absolutely fantastic to transfer some of the SimpleITK great goodies on handling metadata dictionaries to ITK wrappings.

SimpleITK reference: https://simpleitk.readthedocs.io/en/master/link_DicomImagePrintTags_docs.html

phcerdan added a commit to phcerdan/ITK that referenced this issue Dec 14, 2023
@phcerdan
BUG: Fix printing of values in MetaDataObject
e7bce87 
Also removes dead code related to METADATAPRINT

Fix InsightSoftwareConsortium#1454
@phcerdan phcerdan mentioned this issue Dec 14, 2023
Closed
4 tasks
phcerdan added a commit to phcerdan/ITK that referenced this issue Dec 14, 2023
@phcerdan
BUG: Fix printing of values in MetaDataObject
c1b352c 
Also removes dead code related to METADATAPRINT

Fix InsightSoftwareConsortium#1454
phcerdan added a commit to phcerdan/ITK that referenced this issue Dec 14, 2023
@phcerdan
BUG: Fix printing of values in MetaDataObject
1afdbce 
Also removes dead code related to METADATAPRINT

Fix InsightSoftwareConsortium#1454
blowekamp added a commit to blowekamp/ITK that referenced this issue Aug 21, 2024
@blowekamp
BUG: Fix printing of values in MetaDataObject
d297203 
Also removes dead code related to METADATAPRINT

Fix InsightSoftwareConsortium#1454

Co-Author: Pablo Hernandez-Cerdan <pablo.hernandez.cerdan@outlook.com>
@blowekamp blowekamp mentioned this issue Aug 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phcerdan phcerdan

Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Milestone
No milestone
2 participants
@blowekamp @phcerdan