Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorize null handling in equal functions #108

Closed
hadrienk opened this issue Sep 24, 2021 · 0 comments
Closed

Factorize null handling in equal functions #108

hadrienk opened this issue Sep 24, 2021 · 0 comments
Assignees
@romaintailhurat
Labels
S Small
Milestone
Version 0.4.0

Comments

@hadrienk
Copy link
Collaborator

A lot of null checks are identical in the ComparisonVisitor class. I suspect we can improve this.

(90, 28) // TODO: factorize null handling in equal functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romaintailhurat romaintailhurat

Labels
S Small
Projects
None yet
Milestone
Version 0.4.0
Development

No branches or pull requests
4 participants
@hadrienk @FranckCo @romaintailhurat @NicoLaval