Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T54A] Pipeline reproduction (FSL - deriv) #76

Open
7 of 9 tasks
bclenet opened this issue Aug 29, 2023 · 2 comments
Open
7 of 9 tasks

[T54A] Pipeline reproduction (FSL - deriv) #76

bclenet opened this issue Aug 29, 2023 · 2 comments
Labels
deriv FSL ✨ goal: improvement Improvement to an existing feature

Comments

@bclenet
Copy link
Collaborator

bclenet commented Aug 29, 2023

Softwares

FSL v 5.0.9; RRID:SCR_002823 , fmriprep v.1.1.4

Input data

derivatives (fMRIprep)

Additional context

This pipeline is (almost) reproduced, only refactoring should be needed.

List of tasks

Please tick the boxes below once the corresponding task is finished. 👍

  • 👌 A maintainer of the project approved the issue, by assigning a 🏁status: ready for dev label to it.
  • 🌳 Create a branch on your fork to start the reproduction.
  • 🌅 Create a file team_{team_id}.py inside the narps_open/pipelines/ directory. You can use a file inside narps_open/pipelines/templates as a template if needed.
  • 📥 Create a pull request as soon as you completed the previous task.
  • 🧠 Write the code for the pipeline, using Nipype and the file architecture described in docs/pipelines.md.
  • 📘 Make sure your code is documented enough.
  • 🐍 Make sure your code is explicit and conforms with PEP8.
  • 🔬 Create tests for your pipeline. You can use files in tests/pipelines/test_team_* as examples.
  • 🔬 Make sure your code passes all the tests you created (see docs/testing.md).
@bclenet bclenet added the 🏁 status: ready for dev Ready for work label Aug 29, 2023
@bclenet bclenet mentioned this issue Aug 29, 2023
8 tasks
@bclenet bclenet self-assigned this Jan 9, 2024
@bclenet bclenet moved this from In progress to Needs improvement in NARPS Open Pipelines | Reproductions Jan 31, 2024
@bclenet bclenet added the ✨ goal: improvement Improvement to an existing feature label Jan 31, 2024
@bclenet
Copy link
Collaborator Author

bclenet commented Jan 31, 2024

Here are the correlation results for T54A. Improvement is needed.

Team Number of subjects Test status Correlation values
T54A 108 failure [0.83, 0.72, 0.83, 0.72, 0.70, 0.70, 0.70, 0.70, -0.01]

@bclenet bclenet removed their assignment Jan 31, 2024
@cmaumet cmaumet changed the title [T54A] Pipeline reproduction [T54A] Pipeline reproduction (FSL - deriv) Feb 12, 2024
@bclenet
Copy link
Collaborator Author

bclenet commented Apr 12, 2024

It looks like the regressors of interest are not orthogonalized in the code, although mentioned in the description (section independent_vars_first_level):

  • Gain: Modeled for trials with a valid response (Not NoResp), [...], orthoganlized with respect to the constant factor.
  • Loss: Modeled for trials with a valid response (Not NoResp), [...], orthoganalized with respect to the constant factor.
  • Difficulty: Modeled for trials with a valid response (Not NoResp), [...], orthogonalized with respect to the constant factor.

This can be done using the orthogonalization parameter in FSL's Level1Design.

@bclenet bclenet removed the 🏁 status: ready for dev Ready for work label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deriv FSL ✨ goal: improvement Improvement to an existing feature
Projects
Status: Needs improvement
Development

No branches or pull requests

2 participants