Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide tx value when estimating gas #10

Closed
Inphi opened this issue Feb 25, 2022 · 0 comments
Closed

Provide tx value when estimating gas #10

Inphi opened this issue Feb 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Inphi
Copy link
Owner

Inphi commented Feb 25, 2022 •
edited
Loading

Context: https://github.com/maticnetwork/polygon-rosetta/pull/25/

This is not an issue on Optimism right now because our l2geth is based on an older version of geth that isn't affected by this bug. However, post-bedrock, we'll be using the latest upstream, vanilla geth.

The estimateGas Value arg isn't used on Optimism so it won't hurt to add it right now to avoid breakage in the future.
@Inphi Inphi added the enhancement New feature or request label Feb 25, 2022
@Inphi Inphi closed this as completed in 44fa016 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Inphi