Highlighting logic was decoupled from the component TRNG-1479 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Gusinuhe
force-pushed
the
feature/abstract-highlighting-TRNG-1479
branch
from
2fa4b30
to
030d267
Compare
SimonTheSourcerer
suggested changes
Mar 22, 2021
Gusinuhe
force-pushed
the
feature/abstract-highlighting-TRNG-1479
branch
from
ee71054
to
0262353
Compare
SimonTheSourcerer
previously approved these changes
Mar 25, 2021
tomwim
previously approved these changes
Mar 26, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Gusinuhe
force-pushed
the
feature/abstract-highlighting-TRNG-1479
branch
from
bda8950
to
370ccd0
Compare
tomwim
approved these changes
Mar 26, 2021
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR decouples highlighting logic.
Type of change
How Has This Been Tested?
Just try all the combinations possible with the highlight behavior, highlight property, and the highlight interactable.
Relates