Add simulator to xr rig list TRNG-1398 #82
Conversation
| internal class XRSimulatorImporter | ||
| { | ||
| public string SimulatorRigPath = null; | ||
| public string SimulatorPathKey = null; |
There was a problem hiding this comment.
It is a key used to save and retrieve the path to the XR Rig Simulator prefab in EditorPrefs.
| simulator.transform.SetParent(actionRig.transform); | ||
| GameObject prefab = PrefabUtility.SaveAsPrefabAsset(actionRig, simulatorRigPath); | ||
|
|
||
| EditorPrefs.SetString(SimulatorPathKey, simulatorRigPath); |
There was a problem hiding this comment.
Editor Prefs are for the editor not the project. Is this on purpose?
There was a problem hiding this comment.
Yes, this only meant to use if the XR Simulator is not existing and the user sets a training scene from the innoactive menu.
| string filter = $"t:Prefab {prefabName}"; | ||
| string[] prefabsGUIDs = AssetDatabase.FindAssets(filter, new[] {$"Assets/{searchFolder}"}); | ||
|
|
||
| foreach (string prefabGUID in prefabsGUIDs) |
There was a problem hiding this comment.
why is this a foreach, when this loop is only used for one object anyway
There was a problem hiding this comment.
potato, patata
I could just use a (Linq) First method but I would need to validate if the result is not null, I can do it if makes sense to keep it more transparent.
|
Simulator as shitty to use as always, but I am able to use it :D |
Gusinuhe
dismissed
SimonTheSourcerer’s stale review
This review is blocking the testing version, the changes are already addressed.
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This PR generates a new
[XR_Setup_Simulator](if it does not exist) and place it in theXR Interaction Component´s Resources folder, it also enables a new dynamic XR Rig for the simulator and validates when can be used.Type of change
How Has This Been Tested?
Use the set up as a training scene and try the
XR Simulator.Known issues
There might be error messages when importing the
[XR_Setup_Simulator]:RuntimeConfguratoris missing or there are multipleTrainees.