Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snap zones do not lose validation material anymore #59

Merged

Conversation

Maxsiom
Copy link
Contributor

@Maxsiom Maxsiom commented Sep 9, 2020

Description

When the snap zone settings were lost, a new material was created. It overrid the old default material. This lead to losing the validation material in previous configured snap zones because the old material was removed.

Fixes: TRNG-1070

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Create a snap zone with the generator
  2. Play scene
  3. Stop scene
  4. Create new snap zones with the generator
  5. Sporadically the previous (old) snap zones lost the validation material
  6. Somehow sometimes the settings were set to null and thus a new validation material was created which overrid the old material. Thus all old snap zones lost their validation material.

Checklist

  • My code follows the Coding Conventions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Maxsiom
Copy link
Contributor Author

Maxsiom commented Sep 9, 2020

It can be discussed if we want to have such a solution. It does not fix the actual problem why sometimes the SetupValidationMaterial() method is called randomly and overrides the old material. I could not find a real issue there. But this fix works for me. Unfortunately, the problem occurs very randomly for me at the moment. So I cannot test if the whole snapzone settings are lost and all the setup methods get called, when this problem occurs. But I also "fixed" the other methods.

When the snap zone settings were lost, a new material was created.
It overrid the old default material. This lead to losing the validation material
in previous configured snap zones because the old material was removed.
@Maxsiom Maxsiom force-pushed the fix/snapzones-do-not-lose-validation-material-TRNG-1070 branch from f75f487 to 67186a1 Compare September 11, 2020 13:59
@Maxsiom Maxsiom merged commit e5580be into develop Sep 16, 2020
@Maxsiom Maxsiom deleted the fix/snapzones-do-not-lose-validation-material-TRNG-1070 branch September 16, 2020 09:59
@ci-innoactive
Copy link
Collaborator

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants