fix: highlight now draws all submeshes not only the first #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InteractableHighlighter only drew the first submesh of the mesh filter. Now it draws all submeshes.
Maxsiom
requested review from
tomwim,
Gusinuhe,
SimonTheSourcerer and
aleksei-korolev
…-the-first-TRNG-1061
|
@SimonTheSourcerer doesn't this PR becomes obsolete with our tickets? |
Why would it? |
tomwim
approved these changes
Aug 28, 2020
3 tasks
SimonTheSourcerer
approved these changes
Aug 31, 2020
|
It does not get obsolete, it looks perfect and should merged asap |
aleksei-korolev
approved these changes
Aug 31, 2020
SimonTheSourcerer
deleted the
fix/higlight-draws-all-submeshes-not-only-the-first-TRNG-1061
branch
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The InteractableHighlighter only drew the first submesh of the mesh filter.
Now it draws all submeshes.
Fixes: # TRNG-1061
Type of change
How Has This Been Tested?
Using different objects with multiple meshes (submeshes) like the winkelschrauber.fbx provided in this ticket. Then highlight it with the highlight behavior.
Test Configuration:
Aditional Notes
Checklist