Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added executionSide prop to trade objects #78

Merged
merged 4 commits into from
Sep 15, 2022
Merged

fix: added executionSide prop to trade objects #78

merged 4 commits into from
Sep 15, 2022

Conversation

afterburn
Copy link
Contributor

@afterburn afterburn commented Sep 15, 2022 •
edited
Loading

This PR makes the executionSide property visible on trade objects so we can use it to filter for either maker or taker side in our products.

@afterburn afterburn changed the title fix: added executionSide field to trade objects fix: added executionSide prop to trade objects Sep 15, 2022
@bangjelkoski bangjelkoski merged commit 35da59c into master Sep 15, 2022
@bangjelkoski bangjelkoski deleted the fix/trade-execution-side-field branch September 15, 2022 11:57
@bangjelkoski
Copy link
Collaborator

Updated, use ncu | grep @injective and update to the latest packages, most of them got updated because there was a change on the @injectivelabs/ts-types package. @afterburn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangjelkoski bangjelkoski bangjelkoski approved these changes

@ThomasRalee ThomasRalee Awaiting requested review from ThomasRalee

@shane-moore shane-moore Awaiting requested review from shane-moore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterburn @bangjelkoski