Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTIFICATION_RESPONSE_NO_UPDATES and NOTIFICATION_RESPONSE_UPDATES are unused #2

Open
campbell-brown opened this issue Jul 29, 2024 · 1 comment

Comments

@campbell-brown
Copy link

This library seems to define NOTIFICATION_RESPONSE_NO_UPDATES and NOTIFICATION_RESPONSE_UPDATES (in cy_ota_api.h), but not use them.

Example code (e.g. the mtb-example-ota-mqtt repository) uses these values to send responses to the device.

I have run into the issue where I am sending NOTIFICATION_RESPONSE_NO_UPDATES to the device and it performs an upgrade anyway.

Are these intended to be used but not implemented yet? Or were they once used and since been removed? Or do I misunderstand how this all works?

@campbell-brown
Copy link
Author

I also notice that NOTIFICATION_RESPONSE_RESULT_RECEIVED is unused: https://github.com/search?q=repo%3AInfineon%2Fota-update%20NOTIFICATION_RESPONSE_RESULT_RECEIVED&type=code

/**
 * @brief Publisher response when receiving results.
 */
#define NOTIFICATION_RESPONSE_RESULT_RECEIVED   "Result Received"

How is this intended to be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant