Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to see all exit status together with the character item #512

Open
primeapple opened this issue Jul 10, 2024 · 0 comments
Open
Labels
🌊 enhancement New feature or request

Comments

@primeapple
Copy link
Contributor

primeapple commented Jul 10, 2024

Is your feature request related to a problem? Please describe

I want to see the exit code of successful commands and commands that exit with 1, but still want to have the character item, as it contains not only the exit status icon but also the vi icon, which is crucial to me.

Describe the solution you'd like

Don't make the code in the status item depend on the character item at all. Instead give it another option like: hide_common_codes and only hide the 0 and 1 exit code if this option is given.

See my comment on this PR: #500 (comment) , which may fix this.

Additional context

Link to character docs: https://github.com/IlanCosman/tide/wiki/Configuration#character
Link to status docs: https://github.com/IlanCosman/tide/wiki/Configuration#status
Link to status implementation: https://github.com/IlanCosman/tide/blob/main/functions/_tide_item_status.fish
Link to status tests: https://github.com/IlanCosman/tide/blob/main/tests/_tide_item_status.test.fish

@primeapple primeapple added the 🌊 enhancement New feature or request label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant