Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fish_right_prompt to fish_right_prompt.fish #45

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Move fish_right_prompt to fish_right_prompt.fish #45

merged 2 commits into from
Nov 11, 2020

Conversation

jorgebucaran
Copy link
Contributor

@jorgebucaran jorgebucaran commented Nov 11, 2020 •
edited
Loading

If we keep the fish_right_prompt function in fish_prompt, it stays defined in the session even if one uninstalls Tide.

@IlanCosman
Copy link
Owner

Good catch! I remember noticing this and then not doing anything about it 😅

@IlanCosman IlanCosman merged commit 92a3459 into IlanCosman:main Nov 11, 2020
@jorgebucaran jorgebucaran deleted the patch-1 branch November 11, 2020 16:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IlanCosman IlanCosman IlanCosman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgebucaran @IlanCosman