Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am using vi mode and the green I and red N show up above so I have a three line prompt #26

Closed
matthiasdebernardini opened this issue Sep 15, 2020 · 6 comments
Labels
🌊 enhancement New feature or request

Comments

@matthiasdebernardini
Copy link

matthiasdebernardini commented Sep 15, 2020

Fish version 3.1.2 on Ubuntu 18

I switched to tide because pure was not handling tmux correctly (the prompt kept printing weird characters) by the way you should advertise this as a feature that it plays nice with tmux.

However below you can see it causes a three line prompt - how can I make that go away but keep vi mode?

Pure handles vi mode by switching reversing the direction of the arrow depending on if youre in insert mode or normal mode - its really minimal and I like it.

Is it possible to add something like this?

image

@matthiasdebernardini matthiasdebernardini added the ❓ question This issue is a question label Sep 15, 2020
@IlanCosman
Copy link
Owner

For sure; I'm working on it now. One issue to consider is that Tide offers multiple styles. I'll try to find a way to make this work for both the minimal and powerline styles.

@IlanCosman IlanCosman added 🌊 enhancement New feature or request and removed ❓ question This issue is a question labels Sep 15, 2020
@IlanCosman
Copy link
Owner

Hi @matthiasdebernardini, can you try installing Tide from the vi_mode branch and playing around with it?

curl -sL git.io/tide | source && tide_install vi_mode

@matthiasdebernardini
Copy link
Author

sure, but do I have to uninstall it first?

@IlanCosman
Copy link
Owner

IlanCosman commented Sep 20, 2020

No.

@matthiasdebernardini
Copy link
Author

TLDR: works well so far

This is all with tmux btw

I am trying to add as much info that you might find interesting.
Screenshot 2020-09-21 at 13 30 42

`❯ curl -sL git.io/tide | source && tide_install vi_mode
Installing tide theme...
set: Erase needs a variable name

~/.config/fish/tide_theme/configure/choices/all/finish.fish (line 24):
set -e fake_tide_right_prompt_items[(contains --index 'vi_mode' $fake_tide_right_prompt_items)] # No need for vi_mode if prompt_char is activated
^
in function '_tide_finish'
called on line 39 of file -
in function '_tide_actual_install' with arguments 'vi_mode'
called on line 23 of file -
in function 'tide_install' with arguments 'vi_mode'

(Type 'help set' for related documentation)
Tide theme installed!
`

`Choice [y/n] y
set: Erase needs a variable name

~/.config/fish/tide_theme/configure/choices/all/finish.fish (line 24):
set -e fake_tide_right_prompt_items[(contains --index 'vi_mode' $fake_tide_right_prompt_items)] # No need for vi_mode if prompt_char is activated
^
in function '_tide_finish'
called on line 14 of file ~/.config/fish/tide_theme/configure/choices/all/finish.fish
in function 'finish'
called on line 33 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_next_choice' with arguments 'all/finish'
called on line 21 of file ~/.config/fish/tide_theme/configure/choices/all/prompt_spacing.fish
in function 'prompt_spacing'
called on line 33 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_next_choice' with arguments 'all/prompt_spacing'
called on line 16 of file ~/.config/fish/tide_theme/configure/choices/all/prompt_connection_andor_frame_color.fish
in function 'prompt_connection_andor_frame_color'
called on line 33 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_next_choice' with arguments 'all/prompt_connection_andor_frame_color'
called on line 21 of file ~/.config/fish/tide_theme/configure/choices/pure/pure_prompt_height.fish
in function 'pure_prompt_height'
called on line 33 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_next_choice' with arguments 'pure/pure_prompt_height'
called on line 21 of file ~/.config/fish/tide_theme/configure/choices/pure/pure_show_time.fish
in function 'pure_show_time'
called on line 33 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_next_choice' with arguments 'pure/pure_show_time'
called on line 19 of file ~/.config/fish/tide_theme/configure/choices/pure/pure_nonperm_content_location.fish
in function 'pure_nonperm_content_location'
called on line 33 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_next_choice' with arguments 'pure/pure_nonperm_content_location'
called on line 34 of file ~/.config/fish/tide_theme/configure/choices/all/style.fish
in function 'style'
called on line 33 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_next_choice' with arguments 'all/style'
called on line 27 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_tide_begin'
called on line 23 of file ~/.config/fish/functions/_tide_sub_configure.fish
in function '_tide_sub_configure'
called on line 16 of file ~/.config/fish/functions/tide.fish
in function 'tide' with arguments 'configure'
called on line 54 of file -
in function '_tide_actual_install' with arguments 'vi_mode'
called on line 23 of file -
in function 'tide_install' with arguments 'vi_mode'

(Type 'help set' for related documentation)
`
Screenshot 2020-09-21 at 13 34 56
Screenshot 2020-09-21 at 13 35 07

love it!

Thanks so much for quickly patching this - this is a great prompt.

@IlanCosman
Copy link
Owner

Oh, yeah, all of those errors are from using the install script while Tide is already installed. Thanks a ton for opening this issue and helping me test it 😄

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌊 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants