Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tide prompt item GO similiar to RUST support #174

Closed
wants to merge 2 commits into from
Closed

Add tide prompt item GO similiar to RUST support #174

wants to merge 2 commits into from

Conversation

dr-emacs
Copy link
Contributor

Description

Added prompt item for GO indicating go version number and small gopher icon

How Has This Been Tested

  • [ X ] I have tested using Linux.
  • I have tested using MacOS.

Checklist

  • I have updated the documentation accordingly.
  • [ X ] I have updated the tests accordingly.

@dr-emacs dr-emacs marked this pull request as draft July 12, 2021 20:36
@dr-emacs dr-emacs marked this pull request as ready for review July 13, 2021 10:05
IlanCosman added a commit that referenced this pull request Jul 14, 2021
Co-authored-by: Dr. Stephan Heuer <dshr153@gmail.com>
IlanCosman added a commit that referenced this pull request Jul 14, 2021
Co-authored-by: Dr. Stephan Heuer <dshr153@gmail.com>
@IlanCosman
Copy link
Owner

Great work 👍 Merged into the v5 branch with a few small tweaks. Thanks for contributing 😄

@IlanCosman IlanCosman closed this Jul 14, 2021
@dr-emacs
Copy link
Contributor Author

dr-emacs commented Jul 14, 2021

Thank you! My first pull reuest ...
When exchanging the gopher icon in my second commit I noticed a very strange behaviour. Somehow the writing direction seems to switch to right to left. At least this improved only after switching from a numeric only 1.16.5 to go1.16.5.
Maybe you have got en idea?

I'm currently planning to implement a prompt item showing the current battery level. Would that be interesting too?

@IlanCosman
Copy link
Owner

IlanCosman commented Jul 14, 2021

When exchanging the gopher icon in my second commit I noticed a very strange behaviour. Somehow the writing direction seems to switch to left to right. At least this improved only after switching from a numeric only 1.16.5 to go1.16.5.

I noticed that too, so I just used a different gopher icon 😂 No idea why that specific character is weird.

I'm currently planning to implement a prompt item showing the current battery level. Would that be interesting too?

Sure! I think it might be difficult though with different operating systems and whatnot 😄

@dr-emacs
Copy link
Contributor Author

dr-emacs commented Jul 14, 2021

I am only able to test on Linux. I think I'll have to check for the linux specific /sys/class/power_supply. Maybe somebody else will be able to pick up from there ...
Are there more missing/needed prompt items?
I switched from ksh to bash to zsh to fish and used the current IP, battery level, free memory, CPU temperature, system load zsh prompt items.

@IlanCosman
Copy link
Owner

If you're really interested in slaving away 😄 then Spacefish has a bunch of items that might be nice to port over. Specifically, kubectl has been requested for Tide in the past.

As for the ones you mentioned, I don't find them useful, and they're probably fairly annoying to implement due to the aforementioned OS issue, but if you want to, go ahead 😄

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants