Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chruby #100

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Add chruby #100

merged 2 commits into from
Feb 28, 2021

Conversation

pusewicz
Copy link
Contributor

@pusewicz pusewicz commented Feb 16, 2021

Supersedes #92.

Being more explicit about the item (and the tools it is using) is better for the experience.

Users then can add whatever tool they use, such as rbenv or rvm as separate items.

@pusewicz
Copy link
Contributor Author

Wiki documentation:

## chruby

| Variable        | Description                                | Type    |
| --------------- | -------------------------------------------| ------- |
| bg_color        | background color of chruby item            | color   |
| color           | color of chruby item                       | color   |
| icon            | icon to display next to the chruby version | string  |

@pusewicz
Copy link
Contributor Author

I've rebased against main @IlanCosman.

Copy link
Owner

@IlanCosman IlanCosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few copy-paste errors, like deleting the tide_rust.* variables in the classic config. Also, you added in a tide_chruby_verbose_version that doesn't exist 😄

Copy link
Owner

@IlanCosman IlanCosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add chruby to the tide_right_prompt_items list in each config, since it will now be automatically removed if type -q chruby fails.

@IlanCosman IlanCosman added this to the v4.2.0 milestone Feb 24, 2021
@pusewicz
Copy link
Contributor Author

@IlanCosman Done!

@IlanCosman
Copy link
Owner

@pusewicz Can I ask how you're using chruby through fish? I'd like to test it out in the wild.

@pusewicz
Copy link
Contributor Author

Sure, I use it on macOS via Homebrew install of https://github.com/JeanMertz/chruby-fish.

Just follow the instructions.

Then install different ruby versions via https://github.com/sstephenson/ruby-build#readme.

@IlanCosman
Copy link
Owner

Bah I'm too lazy 😂 Do you know the difference between RUBY_AUTO_VERSION and RUBY_VERSION?

@IlanCosman IlanCosman merged commit 4f621ea into IlanCosman:main Feb 28, 2021
@IlanCosman
Copy link
Owner

Thanks for your contribution @pusewicz 😄

@IlanCosman
Copy link
Owner

Oh @pusewicz, can you add the chruby variable documentation to the wiki? Kind of annoying that it isn't better integrated.

@pusewicz
Copy link
Contributor Author

pusewicz commented Mar 1, 2021

@IlanCosman Done!

@pusewicz pusewicz deleted the add-chruby branch March 1, 2021 12:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants