Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular progress value and keyframes names #1543

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

desig9stein
Copy link
Contributor

closes #1542

@didimmova
Copy link
Contributor

When in RTL mode, the circular progress should remain filling clockwise.

@simeonoff
Copy link
Collaborator

When in RTL mode, the circular progress should remain filling clockwise.

Why?

@didimmova
Copy link
Contributor

When in RTL mode, the circular progress should remain filling clockwise.

Why?

https://m3.material.io/components/progress-indicators/guidelines#ee16854f-800e-4470-a102-8d01918582b4
Screenshot 2025-01-28 at 14 12 19

@simeonoff
Copy link
Collaborator

When in RTL mode, the circular progress should remain filling clockwise.

Why?

https://m3.material.io/components/progress-indicators/guidelines#ee16854f-800e-4470-a102-8d01918582b4 Screenshot 2025-01-28 at 14 12 19

Thank you!

@simeonoff simeonoff self-requested a review January 29, 2025 08:37
@simeonoff simeonoff merged commit f162937 into master Feb 3, 2025
5 checks passed
@simeonoff simeonoff deleted the mpopov/progressbar/refactor-progressbar branch February 3, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular progress bar - value should scale with the diameter
3 participants