Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy response headers break message parsing #347

Closed
Thomas-Gelf opened this issue Apr 11, 2022 · 2 comments
Closed

Proxy response headers break message parsing #347

Thomas-Gelf opened this issue Apr 11, 2022 · 2 comments
Assignees
@Thomas-Gelf
Labels
bug
Milestone
v1.3.1

Comments

@Thomas-Gelf
Copy link
Contributor

A configured HTTP proxy can break our HTTP response parsing in vSphereDB >= v1.2. This does not affect all requests, but at least the very first one on a specific curl-initiated connection. Depending on your PHP and CURL version, the behavior can differ.
@Thomas-Gelf Thomas-Gelf self-assigned this Apr 11, 2022
@Thomas-Gelf Thomas-Gelf added this to the v1.3.1 milestone Apr 11, 2022
@Thomas-Gelf
Copy link
Contributor Author

PHP 7.3 ships with CURLOPT_SUPPRESS_CONNECT_HEADERS, former versions don't. Special care needs to be taken when manually stripping proxy headers: as of connection re-use, they appear only on the very first response on each effective connection - and afaik we're not told by curl, whether it created a new one.

@Thomas-Gelf
Copy link
Contributor Author

Fixed with fb661c2 (master, requires incubator v1.5) and 48e7440 (still requires 1.4, names 1.5 in the documentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thomas-Gelf Thomas-Gelf

Labels
bug
Projects
None yet
Milestone
v1.3.1
Development

No branches or pull requests
1 participant
@Thomas-Gelf