Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputfilter does not work, if check state did not change, but Output did. #741

Closed
RincewindsHat opened this issue Apr 12, 2023 · 2 comments

Comments

@RincewindsHat
Copy link
Member

Describe the bug

If the output of a check changed, but the state did not, the output is not written to the SQL backend and therefore not available for the filter.
This is rather irritating (and also functionally problematic).

@nilmerg
Copy link
Member

nilmerg commented Apr 12, 2023

Yeah, that's a known limitation, but Web can't do anything about it. The only solution would be to filter the results after retrieval from the database, but then this may lead to an empty page. (in the worst case)

And what's more irritating, a filter that doesn't work or just empty pages from 1 to 200 or maybe even only every second page?

Background:

If we find results in the database and they'll span over 200 pages, we fetch only a single page. For this page of results, we fetch states from Redis and update the results. To make the filter work, we would need to filter these, say 25, results. This may lead to the case that the page is empty after that because none of the 25 entries matched the filter. We could of course fetch more entries from the database to fill the page up again to 25 results, but then the pagination (limit + offset) on database level is off and broken.

@nilmerg nilmerg closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2023
@Saeid-Abadi
Copy link
Member

ref/NC/836301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants