Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Please add a possibility to mitigate the checkresult from "unknown" to "ok" if no checks could be added to a package #217

Closed
K0nne opened this issue Jul 20, 2021 · 5 comments · Fixed by #218
Assignees

Comments

@K0nne
Copy link
Contributor

K0nne commented Jul 20, 2021

Expected Behavior

I whould love to have a way to mitigate the checkresult to "OK" if a check can not be added to the package.

Current Behavior

I have a few hyper-v checks, which sometimes go "unknown", because the things to check are currently not available. In my case this is not necessary a problem.

Example: The perfcounters to check are only available if client vms exist at the host
20-07-_2021_11-36-17

Example: Overcommitment is not used
20-07-_2021_16-12-19

Possible Solution

Add a parameter to toggle the behaviour between OK and UNKNOWN.

Context

If the hyperv hosts have no client vms (e.g. a new cluster or hosts in maintenance) the "unknown" distracts the users.

@LordHepipud
Copy link
Collaborator

LordHepipud commented Jul 20, 2021

Thank you for the issue. This is not a feature request, but a bug. This package should never throw unknown in case no packages are configured.
I assume there are no machines on this system configured?

Sidenote: For the Performance counters I will add a flag to configure it. Should have read the entire issue :D

@LordHepipud LordHepipud self-assigned this Jul 20, 2021
@K0nne
Copy link
Contributor Author

K0nne commented Jul 21, 2021

Yes, this is a new cluster. The hosts currently have no client VMs configured.

@LordHepipud LordHepipud transferred this issue from Icinga/icinga-powershell-framework Jul 27, 2021
@LordHepipud
Copy link
Collaborator

Fixed the overcommitment in; Icinga/icinga-powershell-hyperv#41

@K0nne
Copy link
Contributor Author

K0nne commented Jul 28, 2021

We are going to test this tomorrow.
Unfortunately the hyperv checks Invoke-IcingaCheckHyperVSnapshot and Invoke-IcingaCheckHyperVVirtualSwitches are also affected:

[UNKNOWN] VM Snapshots: No checks added to this package

[UNKNOWN] Virtual Switches: No checks added to this package

@LordHepipud
Copy link
Collaborator

Could you please open a new issue on the Hyper-V repository for this? A simple Copy&Paste would be enough.

I will provide a PR for this day.

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants