Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Check features test #97 #101

Closed
wants to merge 35 commits into from
Closed

Conversation

androsrivas
Copy link
Collaborator

Changes:

  • All test have been modified, except CollaboratorTest and FaqsTest due to my inability to solve the issues.
  • Created a FaqResource to better pass data to json response.
  • Update method in AppController modified to suit the translatable functionality.
  • Exception\Handler modifed to return suitable error (from 500 to 422).
  • AppTest modified to work with translatable functionality.
  • Added annotations to SendEmailTest to exclude from massive testing. Run php artisan test --exclude-group SendEmailTest.
  • AuthController modified to follow PER specifications.
  • Updated name value in UserController to nullable and corrected the validated data when creating a new User.
  • Corrected some http responses in UserController::forgetPassword method.
  • Corrected error messages in LoginTest.
  • Corrected minor spelling mistakes in ResetPasswordTest.

These are the most important changes I consider should be known.

Right now the following test still fail:

  • CollaboratorTest
    -> index get collaborators landing:
    Error: Expected response status code [200] but received 500.
    -> index get collaborators wiki:
    Error: Expected response status code [200] but received 204.
    -> index get collaborators challenges:
    Error: Expected response status code [200] but received 500.
    -> collaborators logic:
    Error: Failed that JsonResponse Object is of type array.
    -> collaborator landing function:
    Error: array_merge(): Argument must be of type array, Illuminate\Http\JsonResponse given.
    -> collaborator wiki function:
    Error: Failed that JsonResponse Object is of type array.
    -> collaborator challenges function:
    Error: array_merge(): Argument must be of type array, Illuminate\Http\JsonResponse given.

  • FaqsTest
    -> store:
    Error: unable to fins Json structure within response JSON.
    -> store with missing fields:
    Error: Failed to find a validation error in the response for key: 'ca.description'.
    -> store with long title:
    Error: Failed to find a validation error in the response for key: 'title'
    -> update:
    Error: unable to fins Json structure within response JSON.
    -> update with long title:
    Error: Expected response status code [422] but received 200.

levifvy and others added 30 commits July 22, 2023 20:24
…index. add new error message in ca directory.
@androsrivas androsrivas linked an issue Nov 21, 2023 that may be closed by this pull request
@androsrivas
Copy link
Collaborator Author

androsrivas commented Nov 22, 2023

Important change:

  • Included CollaboratorTest to the exlcuding group when it comes to massive testing. Run php artisan test --exclude-group SendEmailTest,CollaboratorTest.

Copy link

sonarcloud bot commented Nov 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 193 Code Smells

No Coverage information No Coverage information
27.8% 27.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] Check features tests
4 participants