From b4b5283bfd4134bfc9320d0fea6a56689c9c83f0 Mon Sep 17 00:00:00 2001 From: candle Date: Thu, 26 Sep 2024 14:53:41 +0200 Subject: [PATCH 1/3] skip lammps tests on windows because it crashes --- .../nanover-lammps/tests/test_lammps_converter.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/python-libraries/nanover-lammps/tests/test_lammps_converter.py b/python-libraries/nanover-lammps/tests/test_lammps_converter.py index 5e692ce9a..b554e1a72 100644 --- a/python-libraries/nanover-lammps/tests/test_lammps_converter.py +++ b/python-libraries/nanover-lammps/tests/test_lammps_converter.py @@ -7,6 +7,16 @@ import sys +pytestmark = pytest.mark.skipif( + sys.platform == "win32", + reason=( + "These tests can break the windows test runner on github. " + "This is tracked in issue #33: " + "." + ), +) + + @pytest.fixture def simple_atom_lammps_frame(): mock = MockLammps() From 56fddb1065fcb8e795df36e944920370eace7f84 Mon Sep 17 00:00:00 2001 From: candle Date: Mon, 30 Sep 2024 11:14:09 +0200 Subject: [PATCH 2/3] style --- .../nanover-lammps/tests/test_lammps_converter.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/python-libraries/nanover-lammps/tests/test_lammps_converter.py b/python-libraries/nanover-lammps/tests/test_lammps_converter.py index b554e1a72..08c3c7f21 100644 --- a/python-libraries/nanover-lammps/tests/test_lammps_converter.py +++ b/python-libraries/nanover-lammps/tests/test_lammps_converter.py @@ -8,12 +8,12 @@ pytestmark = pytest.mark.skipif( - sys.platform == "win32", - reason=( - "These tests can break the windows test runner on github. " - "This is tracked in issue #33: " - "." - ), + sys.platform == "win32", + reason=( + "These tests can break the windows test runner on github. " + "This is tracked in issue #33: " + "." + ), ) From 9a20d753e78955f9aad2e309a9776db93dd82426 Mon Sep 17 00:00:00 2001 From: candle Date: Mon, 30 Sep 2024 11:34:39 +0200 Subject: [PATCH 3/3] adjust some tests --- python-libraries/nanover-essd/tests/test_essd_client_server.py | 2 +- python-libraries/nanover-lammps/tests/test_lammps_converter.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python-libraries/nanover-essd/tests/test_essd_client_server.py b/python-libraries/nanover-essd/tests/test_essd_client_server.py index c1af43e45..776ec0980 100644 --- a/python-libraries/nanover-essd/tests/test_essd_client_server.py +++ b/python-libraries/nanover-essd/tests/test_essd_client_server.py @@ -72,7 +72,7 @@ def test_remove_service(client_server, service): ) assert service in services server.unregister_service(service) - time.sleep(TEST_INTERVAL_TIME) + time.sleep(TEST_SEARCH_TIME) services = set( client.search_for_services( search_time=TEST_SEARCH_TIME, interval=TEST_INTERVAL_TIME diff --git a/python-libraries/nanover-lammps/tests/test_lammps_converter.py b/python-libraries/nanover-lammps/tests/test_lammps_converter.py index 08c3c7f21..ff9694771 100644 --- a/python-libraries/nanover-lammps/tests/test_lammps_converter.py +++ b/python-libraries/nanover-lammps/tests/test_lammps_converter.py @@ -26,7 +26,7 @@ def simple_atom_lammps_frame(): @pytest.fixture def lammps_hook(): - with LammpsImd() as hook: + with LammpsImd(port=0) as hook: yield hook