Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facets filter labels not translated in result block #9408

Closed
luddaniel opened this issue Feb 24, 2023 · 1 comment · Fixed by #10158
Closed

Facets filter labels not translated in result block #9408

luddaniel opened this issue Feb 24, 2023 · 1 comment · Fixed by #10158
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Internationalization Feature: Search/Browse Type: Bug a defect User Role: Guest Anyone using the system, even without an account UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF
Milestone
6.5

Comments

@luddaniel
Copy link
Contributor

luddaniel commented Feb 24, 2023 •
edited
Loading

Hello Dataverse team,

We wanted to report that facet filters are not translated in the top block result after selection.
Here is a screenshot :
facets_fr

Current language is French, on the left panel, values are translated in French but in top block result fragment value are in English (default language for Payara in our case).

Same screnshot with English as language :
facets_en

Which version of Dataverse are you using?

5.12.1

Any related open or closed issues to this bug report?

Issue could be related to #8287 and #8286 but not sure.

Can you do something about it ?
PR is not planned on our side for now.

Regards.
@pdurbin
Copy link
Member

pdurbin commented Feb 28, 2023

@luddaniel thanks for reporting this.

@stevenferey I wonder if we need a fix like the one you recently made:

@pdurbin pdurbin added Type: Bug a defect Feature: Internationalization User Role: Guest Anyone using the system, even without an account Feature: Search/Browse Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF labels Oct 9, 2023
@jeromeroucou jeromeroucou mentioned this issue Nov 30, 2023
Merged
@DS-INRAE DS-INRAE moved this to 🚧 Dev by Recherche Data Gouv in Recherche Data Gouv Jul 10, 2024
@github-project-automation github-project-automation bot moved this from 🚧 Dev by Recherche Data Gouv to Done in Recherche Data Gouv Oct 4, 2024
@pdurbin pdurbin added this to the 6.5 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Internationalization Feature: Search/Browse Type: Bug a defect User Role: Guest Anyone using the system, even without an account UX & UI: New React UI Needs enough design work that it should probably go in the new React UI, not JSF
Projects
Recherche Data Gouv
Status: Done
Milestone
6.5
Development

Successfully merging a pull request may close this issue.

Facets filter labels not translated in result block Recherche-Data-Gouv/dataverse
2 participants
@pdurbin @luddaniel