Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Astronomy metadatablock's .tsv file to match updates to its .properties file, so that updates are applied to English-only installations #9382

Open
jggautier opened this issue Feb 10, 2023 · 1 comment

Comments

@jggautier
Copy link
Contributor

jggautier commented Feb 10, 2023

In the PR at #9367, changes were made in the astrophysics.properties file in order to fix typos in the tooltip text of several fields in the Astronomy and Astrophysics Metadata block.

Here's the diff showing changes made to the tooltip text of three fields:
Screen Shot 2023-02-10 at 11 17 25 AM

The tooltip text of those fields is also in the metadata block's TSV file. Multilingual Dataverse installations (whose “lang” directory is configured) use the text in the metadatablock's .properties files, while "English-only" installations use what's in the database, which is controlled by what's in the metadatablock's TSV files. So the Astronomy and Astrophysics Metadata block's TSV file also needs to be updated to fix the tooltips in English-only installations.

I think it's also best to keep the information in each metadata block's .properties file and .tsv file the same so that people referring to the .tsv files (and the more readable copy in a Google Sheet) see the most up to date versions.

If/when this gets prioritized, I can open a PR to update the astrophysics.tsv file and update the text in the copy of the .tsv file kept in the Google Sheet.

Kind of related I think, is it possible to have both types of installations - multilingual and English-only - use the metadata field names and tooltip text in the .properties files? Then that information could be removed from the .tsv files? Would this simplify updates to metadatablocks in both types of installations?

Alternatively, when this came up in another context, @scolapasta wondered if instead, a script could automate the creation and updating of each metadata block's .properties file, so that what we change is the .tsv file, and then the corresponding .properties file gets updated. Would that help streamline things in the future?

@jggautier jggautier changed the title Update .tsv file of Astronomy and Astrophysics Metadata block to match its .properties file Update .tsv file of Astronomy and Astrophysics Metadata block to match updates to its .properties file and so that updates are applied to English-only installations Feb 14, 2023
@jggautier jggautier changed the title Update .tsv file of Astronomy and Astrophysics Metadata block to match updates to its .properties file and so that updates are applied to English-only installations Update Astronomy metadatablock's .tsv file to match updates to its .properties file, so that updates are applied to English-only installations Feb 14, 2023
@jggautier
Copy link
Contributor Author

jggautier commented Jul 22, 2024

I've revisited this GitHub issue as part of an effort to review and prioritize work proposed in GitHub issues in the IQSS/Dataverse repo that have been opened for years (IQSS/dataverse-pm#114).

As of Dataverse v6.3, the changes made to descriptions/tooltips of three fields in the Astronomy and Astrophysics metadata block's .properties file haven't been made to the metadata block's TSV file.

When I opened this GitHub issue, I wrote that ""English-only" installations use what's in the database, which is controlled by what's in the metadatablock's TSV files", and I assumed that Demo Dataverse and Harvard Dataverse are "English-only" installations. But in those installations, the tooltips of those fields match what's in the metadata block's .properties file, not what's in the TSV file. Specifically, in the tooltips for "Redshift Value", "Redshift Value Minimum" and "Redshift Value Maximum", "km/s" has the closing parenthesis: "value of the redshift (unitless) or Doppler velocity (km/s) in the data object". And the tooltips don't end with "Enter a floating-point number."

So I think that either I'm wrong that "English-only" installations use what's in the metadata block's TSV files, or I'm wrong that Demo Dataverse and Harvard Dataverse are "English-only".

In either case, I still think that for the Astronomy and Astrophysics metadata block, and for all metadata block's, what's in their TSV files should match what's in their .properties files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant