Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6383-editor #6407

Closed
youssefOuahalou opened this issue Nov 25, 2019 · 5 comments
Closed

6383-editor #6407

youssefOuahalou opened this issue Nov 25, 2019 · 5 comments

Comments

@youssefOuahalou
Copy link
Member

Hello,
I have a small problem of adaptation I tried to change the size of line and column but I did not have any change.
I edit the file: datasetFieldForEditFragment.xhtml I changed the tag <p: inputTextarea to become <p: textEditor

datasetFieldForEditFragment.txt
TextEditor

@djbrooke
Copy link
Contributor

djbrooke commented Nov 25, 2019

Hi @youssefOuahalou, as I mentioned in the previous issue (#6353), I'm not sure we want to support this and I would not be inclined to accept a PR for this at this time. Some research needs to happen from an interoperability standpoint and technical standpoint, and we may need to change how we handle some characters in displays. This would be a larger effort and we don't have the bandwidth right now.

The IQSS team is pretty busy with roadmap items (https://www.iq.harvard.edu/roadmaps) and other work, and we're heading into the holidays here in the US. I'm not saying "no" to this, I'm just saying not now. If you can organize members of the community to do some research on the implications and if there's broader interest, we could accelerate this with the community's help, but it's not a problem that's a priority to solve right now.

@mheppler
Copy link
Contributor

@youssefOuahalou, I suggest that you close this issue and continue to use the first issue you opened last week (Markdown wysiwyg #6383), as the issue to track your feature request. In that issue, I am also going to add a comment outlining some of the outstanding metadata support and validation concerns that @djbrooke spoke of in his comment and why this feature request is not as simple as changing the form component in the UI.

For future developer related questions, I suggest you use the Dataverse Dev mailing list, which you can find linked in our Developer Guide.

That said, thank you for providing a code snippet and screenshot, in order to help replicate your issue. It appears this is a simple CSS fix, by removing the Bootstrap form-control style class, as well as removing the rows and cols attributes that are not used with this component, and adding some inline CSS to the PrimeFaces component. (Also added the toolbar facet to customize the formatting options displayed.)

    <p:textEditor value="#{dsfv.valueForEdit}" id="description" pt:aria-required="#{dsf.required}"
                  height="180" style="height:220px;"
                  rendered="#{dsfv.datasetField.datasetFieldType.fieldType == 'TEXTBOX' }">
        <f:facet name="toolbar">
            <span class="ql-formats">
                <select class="ql-font"></select>
                <select class="ql-size"></select>
            </span>
            <span class="ql-formats">
                <button class="ql-bold"></button>
                <button class="ql-italic"></button>
                <button class="ql-underline"></button>
                <button class="ql-strike"></button>
            </span>
        </f:facet>
    </p:textEditor>

Screen Shot 2019-11-25 at 3 31 54 PM

@youssefOuahalou

This comment has been minimized.

@youssefOuahalou
Copy link
Member Author

Thank you very much my concern is solved

@youssefOuahalou
Copy link
Member Author

youssefOuahalou commented Nov 26, 2019

Thank you very much my concern is solved
TextEditorNewdataset
CodeTextEditor
ExempleIphoneX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants