Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions - Improve Descriptions of Roles #4389

Closed
dlmurphy opened this issue Dec 18, 2017 · 7 comments
Closed

Permissions - Improve Descriptions of Roles #4389

dlmurphy opened this issue Dec 18, 2017 · 7 comments
Labels
Feature: Permissions Type: Suggestion an idea User Role: Depositor Creates datasets, uploads data, etc.

Comments

@dlmurphy
Copy link
Contributor

dlmurphy commented Dec 18, 2017

When you assign roles to users on both the dataverse and dataset level, the summaries of those roles are inaccurate and confusing. I'd like to review and rewrite these descriptions. The descriptions are actually populated from the database, so we'll need to change their database values (found in the Description column of the Dataverserole table). We'll then need to write database update scripts for us and for other installations, as well as update existing scripts meant for new installations setting up their databases.

Here are some examples of uninformative/inaccurate descriptions:
roles1
(Obviously, this role allows you to edit more than just the license and terms, it allows you to edit all metadata.)

roles2
(Similar problem here)

Role descriptions need to be edited not just for accuracy, but additionally to make sure they emphasize the main point of each role and important distinctions between roles. This will help alleviate user confusion we've observed (for example, dataverse owners assigning the Contributor role when they meant to give users the permissions of the Dataset Creator role).

@mheppler
Copy link
Contributor

mheppler commented May 4, 2018

In the issue "Roles Description: Update File Downloader Description #3022" it was suggested:

In the UI for roles, we need to add to the description for File Downloader that this is only for published dataverses and datasets.

Closed that issue in favor of this as it is more recent, and includes improving all the descriptions. This should be addressed as part of the DataTags integration #871.

@mheppler mheppler changed the title Improve Descriptions of Roles in UI Permissions - Improve Descriptions of Roles May 4, 2018
@jggautier
Copy link
Contributor

Another example of a role description that could be clarified is the Member role:

screen shot 2018-11-29 at 11 09 17 am

The description doesn't mention that people with the "Member" role can also download files. You might infer this from the listed permission "DownloadFile", but someone thought that that only applied to files when the dataset was unpublished. Once the dataset was published, they didn't expect the person with the Member role to be able to download the files (which were restricted files).

@mheppler
Copy link
Contributor

Related to For some roles, objects are not populated in alert message #5352.

@AACGSR
Copy link
Contributor

AACGSR commented Jan 24, 2020

Hi there. Not sure whether this belongs here or needs an own issue. But we found that the right "DownloadFile" allows people to download restricted files. For not restricted files, even roles without "DownloadFile" can download files. (@RightInTwo created a role "observer" for our dataverse, which has the rights " ViewUnpublishedDataverse" and "ViewUnpublishedDataset" only). This is on Dataverse version 4.11 fyi

@pdurbin
Copy link
Member

pdurbin commented Jan 24, 2020

@AACGSR yeah instead of...

File Downloader - A person who can download a published file.

... maybe it should be called...

Restricted File Downloader - A person who can download a restricted published file.

Here's a screenshot from 4.18.1 for context:

Screen Shot 2020-01-24 at 2 20 42 PM

@RightInTwo
Copy link
Contributor

... maybe it should be called...

Restricted File Downloader - A person who can download a restricted published file.

That sound like you would like to rename the role - wouldn't it make sense to also rename the permission itself to "DownloadRestrictedFile"?

@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Permissions Type: Suggestion an idea User Role: Depositor Creates datasets, uploads data, etc.
Projects
None yet
Development

No branches or pull requests

7 participants