Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdata ingest defaults #3999

Closed
acoppock opened this issue Jul 13, 2017 · 3 comments
Closed

rdata ingest defaults #3999

acoppock opened this issue Jul 13, 2017 · 3 comments
Labels

Comments

@acoppock
Copy link

Would suggest the following logic:

if .rdata contains 1 and only 1 data.frame --> ingest
otherwise do not ingest and simple post the file unmolested.

crucially, if .rdata contains > 1 data.frame, it's odd to ingest the "first" one, however that is determined (alphabetical?)

also, since .rdata files can include other objects beyond data.frames that are very useful, seems best to leave them be.

@djbrooke
Copy link
Contributor

Thanks @acoppock. We're finishing up a big push on improving ingest now (#3767), but we'll revisit the ingest behavior in the future and I hope that we can work with you to make this better.

Note to future self: consider the messaging about how we'd potentially handle ingest differently based on number of data.frames

@pdurbin
Copy link
Member

pdurbin commented Oct 10, 2022

if .rdata contains 1 and only 1 data.frame --> ingest otherwise do not ingest and simple post the file unmolested.

crucially, if .rdata contains > 1 data.frame, it's odd to ingest the "first" one, however that is determined (alphabetical?)

@shlake has the same suggest for Excel ingest. Instead of ingesting the first sheet, like we do now, she thinks ingest should not proceed and the depositor should see a message about this: #8518 (comment)

Also, these issues are related:

@acoppock I remember your excitement over opening #4000 (a nice round number and we fixed it). Before long our issues will have five digits. 😄

Please keep the suggestions coming!

@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants