Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider security implications of deployment to Glassfish via POST #3607

Closed
pdurbin opened this issue Jan 31, 2017 · 4 comments
Closed

Consider security implications of deployment to Glassfish via POST #3607

pdurbin opened this issue Jan 31, 2017 · 4 comments

Comments

@pdurbin
Copy link
Member

pdurbin commented Jan 31, 2017

http://blogs.steeplesoft.com/posts/2011/deploying-applications-to-glassfish-using-curl.html documents how to deploy a war file to Glassfish via POST (as well as how to undeploy using DELETE).

Does Glassfish allow deployment via POST out of the box?

If so, should we document how to disable deployment via POST in the Dataverse Installation Guide?

Should we make the disabling or enabling of deployment via POST a flag in the installer?

@pameyer
Copy link
Contributor

pameyer commented Jan 31, 2017

I'll have to go back to my notes and double-check, but I believe that the glassfish admin server may require a password set and/or "secure remote admin" before allowing admin access from locations other than localhost.

If I'm remembering correctly, the installer uses asadmin (instead of POST) for deployment - but this also needs a double-check.

@pameyer
Copy link
Contributor

pameyer commented Feb 2, 2017

Double-checked (after confirmation from donsizemore http://irclog.iq.harvard.edu/dataverse/2017-01-31 that this was probably the case).

  • Remote access needs to be enabled before Glassfish will allow access to the admin port; this is disabled by default with Glassfish 4.1 (aka - the one Dataverse recommends).
  • Attempting to deploy a WAR via POST out of the box fails as expected from off-host.

Short version - I don't see an additional steps that should be documented to prevent users from running into this. It might be useful to have a URL to "running Glassfish in production for the paranoid" (assuming such a thing exists).

@pameyer
Copy link
Contributor

pameyer commented Feb 2, 2017

Additional clarification - "out of the box" meaning that glassfish was installed as recommended in the guide; and after running the dataverse installer.

@djbrooke djbrooke changed the title Consider security implications of deployment to Glassfish via POST Installation Guide Update - Security Recommendations Feb 24, 2017
@pdurbin pdurbin changed the title Installation Guide Update - Security Recommendations Consider security implications of deployment to Glassfish via POST May 25, 2017
@pdurbin
Copy link
Member Author

pdurbin commented May 25, 2017

I'm satisfied with @pameyer 's findings of "Attempting to deploy a WAR via POST out of the box fails as expected from off-host." Also, we need to circle back to Glassfish security in #1934 anyway so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants