Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: biomedical and customGSD blockv have duplicate enum values #3094

Closed
raprasad opened this issue Apr 27, 2016 · 6 comments
Closed

typo: biomedical and customGSD blockv have duplicate enum values #3094

raprasad opened this issue Apr 27, 2016 · 6 comments

Comments

@raprasad
Copy link
Contributor

raprasad commented Apr 27, 2016

Note: very low priority, spotted while working on schema validation

  1. For studyAssayMeasurementType, the value transcription profiling appears twice
  1. For gsdFacultyName, the value Menges, Achim appears twice

(Very low priority, spotted while working on JSON schema validation. Didn't immediately correct tsv b/c may need to be corrected in the database)

@pdurbin
Copy link
Member

pdurbin commented Apr 27, 2016

Related: tsv metadata block import: add preview mode #2551

@pdurbin
Copy link
Member

pdurbin commented Jul 12, 2018

transcription profiling appears twice

It actually appears four times, some in parenthesis but they all have unique displayName's so I don't think it's a bug: https://github.com/IQSS/dataverse/blob/v4.9.1/scripts/api/data/metadatablocks/biomedical.tsv

It's true that Menges appears twice. Probably a bug. GSD is super Harvard-specific. I guess no one has noticed: https://github.com/IQSS/dataverse/blob/v4.9.1/scripts/api/data/metadatablocks/customGSD.tsv

@scolapasta
Copy link
Contributor

Re: the same value appearing with different display values - it should ideally be one value, and we should have a better way to have more "display values" link to the same value. This has been discussed in the context of subjects. (if the display value is not really a s"synonym" it should have a different value)

@pdurbin
Copy link
Member

pdurbin commented Oct 3, 2022

customGSD.tsv

The GSD block is Harvard-specific. We've started moving this to https://github.com/IQSS/dataverse.harvard.edu

@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
@sbarbosadataverse
Copy link

@cmbz Given that the biomedical block is part of this problem, should we reopen to address in the spa? We'd need to research how much use the block is getting. Was something done recently to suppress errors during the reindexing of datasets? @scolapasta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants