Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style (Sonarlint): use StandardCharsets instead of names as Strings #10076

Closed
bencomp opened this issue Oct 31, 2023 · 0 comments · Fixed by #10077
Closed

Code style (Sonarlint): use StandardCharsets instead of names as Strings #10076

bencomp opened this issue Oct 31, 2023 · 0 comments · Fixed by #10077
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Size: 3 A percentage of a sprint. 2.1 hours. Type: Suggestion an idea User Role: Hackathon Participant Core developers, frequent contributors, drive-by contributors, etc.
Milestone
6.4

Comments

@bencomp
Copy link
Contributor

bencomp commented Oct 31, 2023

Overview of the Feature Request
Prefer constants from StandardCharsets over String values to make code more robust and remove unnecessary try-catch constructs. See Sonar rule java:S4719 for an explanation.

What kind of user is the feature intended for?
Developers

What inspired the request?
Sonarcloud

What existing behavior do you want changed?
None

Any brand new behavior do you want to add to Dataverse?
None

Any open or closed issues related to this feature request?
Not that I know of.
@bencomp bencomp mentioned this issue Oct 31, 2023
Merged
@pdurbin pdurbin added Type: Suggestion an idea Component: Code Infrastructure formerly "Feature: Code Infrastructure" User Role: Hackathon Participant Core developers, frequent contributors, drive-by contributors, etc. labels Nov 12, 2023
@cmbz cmbz added the Size: 3 A percentage of a sprint. 2.1 hours. label Apr 1, 2024
@bencomp bencomp mentioned this issue Aug 14, 2024
Open
@pdurbin pdurbin added this to the 6.4 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Size: 3 A percentage of a sprint. 2.1 hours. Type: Suggestion an idea User Role: Hackathon Participant Core developers, frequent contributors, drive-by contributors, etc.
Projects
None yet
Milestone
6.4
Development

Successfully merging a pull request may close this issue.

Use StandardCharsets instead of charset names bencomp/dataverse
3 participants
@pdurbin @bencomp @cmbz