Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct Upload broken for all but the store with id = 's3' #10018

Closed
qqmyers opened this issue Oct 16, 2023 · 1 comment
Closed

Direct Upload broken for all but the store with id = 's3' #10018

qqmyers opened this issue Oct 16, 2023 · 1 comment
Milestone
6.1

Comments

@qqmyers
Copy link
Member

qqmyers commented Oct 16, 2023

#9003 added a check to make sure that only stores of type s3 respond to the upload-redirect setting (others are supposed to use upload-out-of-band). Unfortunately the code confuses id and type and only allows direct upload for a store with the id=s3 rather than any store of type=s3. PR to follow.
@qqmyers
Copy link
Member Author

qqmyers commented Jan 24, 2024

PR #10019 fixed this - closing

@qqmyers qqmyers closed this as completed Jan 24, 2024
@pdurbin pdurbin added this to the 6.1 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1
Development

No branches or pull requests
2 participants
@pdurbin @qqmyers