From 0caed586e959b63309ffaa20db699e81f262b776 Mon Sep 17 00:00:00 2001 From: Philip Durbin Date: Tue, 5 Dec 2017 12:19:31 -0500 Subject: [PATCH] fix SQL upgrade script to match JPA (unlimited) #4353 --- scripts/database/upgrades/upgrade_v4.8.3_to_v4.8.4.sql | 4 ++-- .../authorization/providers/oauth2/OAuth2TokenData.java | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/scripts/database/upgrades/upgrade_v4.8.3_to_v4.8.4.sql b/scripts/database/upgrades/upgrade_v4.8.3_to_v4.8.4.sql index 61e14c3a08a..670a2d191db 100644 --- a/scripts/database/upgrades/upgrade_v4.8.3_to_v4.8.4.sql +++ b/scripts/database/upgrades/upgrade_v4.8.3_to_v4.8.4.sql @@ -1,2 +1,2 @@ --- Hopefully, 255 characters is enough. Google login has used 131 characters. -ALTER TABLE oauth2tokendata ALTER COLUMN accesstoken TYPE character varying(255); +-- Google login has used 131 characters. 64 is not enough. +ALTER TABLE oauth2tokendata ALTER COLUMN accesstoken TYPE text; diff --git a/src/main/java/edu/harvard/iq/dataverse/authorization/providers/oauth2/OAuth2TokenData.java b/src/main/java/edu/harvard/iq/dataverse/authorization/providers/oauth2/OAuth2TokenData.java index 57e21b8c3b0..db29bae92bd 100644 --- a/src/main/java/edu/harvard/iq/dataverse/authorization/providers/oauth2/OAuth2TokenData.java +++ b/src/main/java/edu/harvard/iq/dataverse/authorization/providers/oauth2/OAuth2TokenData.java @@ -49,9 +49,7 @@ public class OAuth2TokenData implements Serializable { private Timestamp expiryDate; /** - * "TEXT" is 255 characters, which is enough for Google at 131 characters. - * Facebook says, "Please don't put a maximum size on the storage for an - * access token" at + * "Please don't put a maximum size on the storage for an access token" at * https://stackoverflow.com/questions/4408945/what-is-the-length-of-the-access-token-in-facebook-oauth2/16365828#16365828 */ @Column(columnDefinition = "TEXT")