Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noclasspath mode is used but it shouldn't be the case #3325

Closed
vmassol opened this issue Apr 14, 2020 · 3 comments · Fixed by SpoonLabs/spoon-maven-plugin#67
Closed

noclasspath mode is used but it shouldn't be the case #3325

vmassol opened this issue Apr 14, 2020 · 3 comments · Fixed by SpoonLabs/spoon-maven-plugin#67

Comments

@vmassol
Copy link

vmassol commented Apr 14, 2020

Hi,

  1. I see that https://github.com/SpoonLabs/spoon-maven-plugin/blob/master/src/main/java/fr/inria/gforge/spoon/SpoonMojoGenerate.java#L71 sets the noclasspath mode to false by default
  2. I also put <noClasspath>false</noClasspath> in my spoon plugin config.

Yet I get:

[INFO] --- spoon-maven-plugin:3.2:check (spoon-main) @ xwiki-commons-component-api ---
[INFO] Spoon report directory: /Users/vmassol/dev/xwiki/xwiki-commons/xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-api/target/spoon-maven-plugin
[INFO] Generate spoon without a spoon.xml file.
[INFO] Running spoon with classpath:
[INFO] file:/Applications/apache-maven-3.6.2/boot/plexus-classworlds-2.6.0.jar
[INFO] Running in NOCLASSPATH mode (doc: http://spoon.gforge.inria.fr/launcher.html).
[INFO] Running spoon with parameters:
[INFO] [--level, INFO, -i, /Users/vmassol/dev/xwiki/xwiki-commons/xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-api/src/main/java:/Users/vmassol/dev/xwiki/xwiki-commons/xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-api/target/generated-sources/annotations, -o, /Users/vmassol/dev/xwiki/xwiki-commons/xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-api/target/generated-sources/spoon, --compliance, 8, --source-classpath, /Users/vmassol/.m2/repository/org/xwiki/commons/xwiki-commons-stability/12.3-SNAPSHOT/xwiki-commons-stability-12.3-SNAPSHOT.jar:/Users/vmassol/.m2/repository/org/xwiki/commons/xwiki-commons-text/12.3-SNAPSHOT/xwiki-commons-text-12.3-SNAPSHOT.jar:/Users/vmassol/.m2/repository/org/apache/commons/commons-lang3/3.10/commons-lang3-3.10.jar:/Users/vmassol/.m2/repository/org/slf4j/slf4j-api/1.7.30/slf4j-api-1.7.30.jar:/Users/vmassol/.m2/repository/javax/inject/javax.inject/1/javax.inject-1.jar:, -p, org.xwiki.tool.spoon.ForbiddenInvocationProcessor:org.xwiki.tool.spoon.ComponentAnnotationProcessor, --output-type, nooutput]
[INFO] Running in NOCLASSPATH mode (doc: http://spoon.gforge.inria.fr/launcher.html).
[INFO] Spoon version 8.1.0
[INFO] running Spoon...
[INFO] start processing...
[INFO] org.xwiki.tool.spoon.ForbiddenInvocationProcessor
[INFO] org.xwiki.tool.spoon.ComponentAnnotationProcessor
[INFO] end of processing: 
[INFO] no errors, no warnings
[INFO] 

Any idea?

Thanks

@surli surli added the bug label Apr 14, 2020
@surli
Copy link
Collaborator

surli commented Apr 14, 2020

That's a serious regression caused by https://github.com/INRIA/spoon/pull/3242/files#diff-aa0cb99e88cfef20a12f16223180b19eL377 basically we removed the noclasspath mode, but we never refactor the spoon-maven-plugin for it...

We should really incorporate the Spoon Maven Plugin in this repository and test it along with Spoon so we could spot those regressions.

@monperrus
Copy link
Collaborator

fixed in https://github.com/SpoonLabs/spoon-maven-plugin/pull/67/files#diff-6e04d2bbe21096d9338f81f30440c334

@vmassol
Copy link
Author

vmassol commented Apr 15, 2020

Great, thanks @monperrus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants