Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded spacing and missing timestamp if None in convert_to_xarray #18

Open
robert-DL opened this issue Feb 17, 2025 · 0 comments
Open

Comments

@robert-DL
Copy link
Collaborator

robert-DL commented Feb 17, 2025

Hi folks,

in the era5 dataset, the spacing of lats and longs is hardcoded, leading to problems if people use other resolutions than 240x121 and want to store predictions.

https://github.com/INRIA/geoarches/blob/66cd870fdcf737d7bece759458d4aee05f0c0d0a/geoarches/dataloaders/era5.py#L179C9-L196C10

Additionally, the timestamp parameter in convert_trajectory_to_xarray is set to None, but if you do not pass it, convert_to_xarray receives None and can_t handle that as None objects have no cpu() property.
See here:

times = pd.to_datetime(timestamp.cpu().numpy(), unit="s").tz_localize(None)

Best
Robert

@robert-DL robert-DL changed the title Hardcoded spacing in convert_to_xarray Hardcoded spacing and missing timestamp if None in convert_to_xarray Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant