Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Makefile to allow pushing only :dev tag to dockerhub #648

Closed
matentzn opened this issue Aug 5, 2022 · 5 comments · Fixed by #653
Closed

Adjust Makefile to allow pushing only :dev tag to dockerhub #648

matentzn opened this issue Aug 5, 2022 · 5 comments · Fixed by #653
Assignees
Labels
Milestone

Comments

@matentzn
Copy link
Contributor

matentzn commented Aug 5, 2022

If I only push obolibrary/odkfull:dev tag to dockerhub, will people using

docker pull obolibrary/odkfull
docker pull obolibrary/odkfull:latest

be unaffected @gouttegd ?

@matentzn matentzn added this to the 1.3.2 milestone Aug 5, 2022
@gouttegd
Copy link
Contributor

gouttegd commented Aug 5, 2022

If no tag is specified when pulling, the default tag is latest, so people using docker pull obolibrary/odkfull should still get the image tagged latest even if a more recent image with another tag (dev) is also available on the hub.

As for people using docker pull obolibrary/odkfull:latest, the tag is explicitly specified, so again, the mere presence of another and more recent image should not impact them.

@matentzn
Copy link
Contributor Author

matentzn commented Aug 5, 2022

I am thinking of running more regular dev builds. Can you perhaps create a make goal for me (publish-multiarch-dev) that will safely build a multiarch image and push only a dev tag? Not urgent but I think this will make a lot of stuff easier because I can role experimental features out quicker..

@gouttegd
Copy link
Contributor

gouttegd commented Aug 5, 2022

I’m assuming you would only need odkfull, right? You can do without a odklite:dev?

(Not that we can’t do both if needed, of course. But I’d rather implement only what we actually need.)

@matentzn
Copy link
Contributor Author

matentzn commented Aug 5, 2022

yes, only odkfull:dev is totally sufficient (probably better in case docker hub starts putting limits on the size of an org)

@matentzn
Copy link
Contributor Author

Awesome, very very appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants