feat(depots): add loading icon for depot select #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a loading indicator (hourglass) to the bhDepotSelect so that users are aware that the component is loading, even in a slow connection. Closes Third-Culture-Software#5704.
|
@mbayopanda, can I get a review? |
jmcameron
reviewed
Jun 7, 2021
| @@ -1,6 +1,6 @@ | |||
| <div ng-form="DepotForm" bh-depot-select ng-model-options="{ updateOn: 'default' }"> | |||
| <div | |||
| class="form-group" | |||
| class="form-group has-feedback" | |||
There was a problem hiding this comment.
Is this necessary? it seems like we have some forms that use the $loading flag that do not use it.
There was a problem hiding this comment.
Yes, to show the icon on the input, the has-feedback class does the magic.
mbayopanda
approved these changes
Jun 7, 2021
| typeahead-template-url="/modules/templates/depotList.tmpl.html" | ||
| typeahead-on-select="$ctrl.onSelect($item, $model)" | ||
| typeahead-min-length="0" | ||
| autocomplete="off" | ||
| translate-attr="{ 'placeholder': 'FORM.SELECT.DEPOT' }" | ||
| ng-required="$ctrl.required"> | ||
|
|
||
| <span ng-show="$ctrl.$loading" class="glyphicon glyphicon-hourglass form-control-feedback"></span> |
There was a problem hiding this comment.
glyphicon 😄 ça fait très longtemps. 👍🏽
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a loading indicator (hourglass) to the bhDepotSelect so that users are aware that the component is loading, even in a slow connection.
Closes #5704.
Here is what it looks like:
