Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stock): link stock movement transaction #5591

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Apr 26, 2021

Adds the ability to link stock movements with the journal if the automated stock accounting is working. This makes it easy to correlate the financial writings with the stock ones.

Closes #5276.

Here it is in action:

CEzSYAON20

Adds the ability to link stock movements with the journal if the
automated stock accounting is working.

Closes Third-Culture-Software#5276.
@jniles jniles added the Stock label Apr 26, 2021
@jniles jniles requested a review from mbayopanda April 26, 2021 14:04
Copy link
Collaborator

@mbayopanda mbayopanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

bors r+

@@ -160,6 +162,8 @@ function buildTransactionQuery(options, posted) {
filters.equals('hrEntity', 'text', 'em');
filters.equals('hrRecord', 'text', 'dm1');
filters.equals('hrReference', 'text', 'dm2');
filters.equals('entity_uuid');
filters.equals('stockReference', 'reference_uuid', 'p');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@bors
Copy link
Contributor

bors bot commented Apr 27, 2021

Build succeeded:

@bors bors bot merged commit f8d1b6c into Third-Culture-Software:master Apr 27, 2021
@jniles jniles deleted the 5276-feat-link-transactions-with-stock-movement branch April 27, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link the associated transaction for a stock movement if it exists
2 participants